Skip to content

Commit

Permalink
[LLDB]{MIPS] Fix TestPlatformProcessConnect.py
Browse files Browse the repository at this point in the history
Patch by Nitesh Jain

Reviewers: clayborg, labath.
Subscribers: jaydeep, bhushan, mohit.bhakkad, sagar, lldb-commits.
Differential Revision: http://reviews.llvm.org/D18082

llvm-svn: 264030
  • Loading branch information
Mohit7 committed Mar 22, 2016
1 parent 844baa2 commit 19d8067
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 18 deletions.
Expand Up @@ -258,18 +258,3 @@ PlatformAndroidRemoteGDBServer::ConnectProcess(const char* connect_url,
target,
error);
}

size_t
PlatformAndroidRemoteGDBServer::ConnectToWaitingProcesses(Debugger& debugger, Error& error)
{
std::vector<std::string> connection_urls;
GetPendingGdbServerList(connection_urls);

for (size_t i = 0; i < connection_urls.size(); ++i)
{
ConnectProcess(connection_urls[i].c_str(), nullptr, debugger, nullptr, error);
if (error.Fail())
return i; // We already connected to i process succsessfully
}
return connection_urls.size();
}
Expand Up @@ -46,9 +46,6 @@ class PlatformAndroidRemoteGDBServer : public platform_gdb_server::PlatformRemot
lldb_private::Target *target,
lldb_private::Error &error) override;

size_t
ConnectToWaitingProcesses(lldb_private::Debugger& debugger, lldb_private::Error& error) override;

protected:
std::string m_device_id;
std::map<lldb::pid_t, uint16_t> m_port_forwards;
Expand Down
Expand Up @@ -1001,6 +1001,22 @@ PlatformRemoteGDBServer::ConnectProcess(const char* connect_url,
return Platform::ConnectProcess(connect_url, plugin_name, debugger, target, error);
}

size_t
PlatformRemoteGDBServer::ConnectToWaitingProcesses(Debugger& debugger, Error& error)
{
std::vector<std::string> connection_urls;
GetPendingGdbServerList(connection_urls);

for (size_t i = 0; i < connection_urls.size(); ++i)
{
ConnectProcess(connection_urls[i].c_str(), nullptr, debugger, nullptr, error);
if (error.Fail())
return i; // We already connected to i process succsessfully
}
return connection_urls.size();

}

size_t
PlatformRemoteGDBServer::GetPendingGdbServerList(std::vector<std::string>& connection_urls)
{
Expand Down
Expand Up @@ -224,6 +224,9 @@ class PlatformRemoteGDBServer : public Platform
lldb_private::Target *target,
lldb_private::Error &error) override;

size_t
ConnectToWaitingProcesses(lldb_private::Debugger& debugger, lldb_private::Error& error) override;

virtual size_t
GetPendingGdbServerList(std::vector<std::string>& connection_urls);

Expand Down

0 comments on commit 19d8067

Please sign in to comment.