Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GlobalsAA: Functions with the argmemonly attribute won't read arbitra…
…ry globals Summary: In preparation for changing GlobalsAA to stop assuming that intrinsics can't read arbitrary globals, we need to make sure GlobalsAA is querying function attributes rather than relying on this assumption. This patch was inspired by: http://reviews.llvm.org/D20206 Reviewers: jmolloy, hfinkel Subscribers: eli.friedman, llvm-commits Differential Revision: https://reviews.llvm.org/D21318 llvm-svn: 275433
- Loading branch information
1 parent
5bb2842
commit 1b5cf62
Showing
2 changed files
with
32 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
; RUN: opt < %s -disable-basicaa -globals-aa -dse -S | FileCheck %s | ||
|
||
@X = internal global i32 4 | ||
|
||
define void @test0() { | ||
; CHECK-LABEL: @test0 | ||
; CHECK: store i32 0, i32* @X | ||
; CHECK-NEXT: call void @func_readonly() #0 | ||
; CHECK-NEXT: store i32 1, i32* @X | ||
store i32 0, i32* @X | ||
call void @func_readonly() #0 | ||
store i32 1, i32* @X | ||
ret void | ||
} | ||
|
||
define void @test1() { | ||
; CHECK-LABEL: @test1 | ||
; CHECK-NOT: store | ||
; CHECK: call void @func_read_argmem_only() #1 | ||
; CHECK-NEXT: store i32 3, i32* @X | ||
store i32 2, i32* @X | ||
call void @func_read_argmem_only() #1 | ||
store i32 3, i32* @X | ||
ret void | ||
} | ||
|
||
declare void @func_readonly() #0 | ||
declare void @func_read_argmem_only() #1 | ||
|
||
attributes #0 = { readonly } | ||
attributes #1 = { readonly argmemonly } |