Skip to content

Commit

Permalink
Add mention of advantages of arc in the Phabricator doc.
Browse files Browse the repository at this point in the history
Differential Revision: https://reviews.llvm.org/D76952
  • Loading branch information
joker-eph committed Apr 4, 2020
1 parent 179f4ba commit 1ce0bc3
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion llvm/docs/Phabricator.rst
Expand Up @@ -48,7 +48,11 @@ Requesting a review via the web interface
The tool to create and review patches in Phabricator is called
*Differential*.

Note that you can upload patches created through git.
Note that you can upload patches created through git, but using `arc` on the
command line (see previous section) is prefered: it adds more metadata to
Phabricator which are useful for the pre-merge testing system and for
propagating attribution on commits when someone else has to push it for you.

To make reviews easier, please always include **as much context as
possible** with your diff! Don't worry, Phabricator
will automatically send a diff with a smaller context in the review
Expand Down

0 comments on commit 1ce0bc3

Please sign in to comment.