-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MSABI] Remove comdat attribute for inheriting ctor.
Currently, for MS, the linkage for the inheriting constructors is set to internal. However, the comdat attribute is also set like: define internal noundef ptr @"??0?$B@_N@@qeaa@AEBVF@@aebua@@@z"(ptr noundef nonnull returned align 1 dereferenceable(1) %this, ptr noundef nonnull align 1 dereferenceable(1) %0, ptr noundef nonnull align 1 dereferenceable(1) %1) unnamed_addr comdat This could cause linker to fail. The change is to remove comdat attribute for the inheriting constructor to make linker happy. Differential Revision: https://reviews.llvm.org/D158538
- Loading branch information
Showing
3 changed files
with
57 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// RUN: %clang_cc1 -fcxx-exceptions -triple=x86_64-windows-msvc -emit-llvm %s -o - | FileCheck %s | ||
|
||
class F { | ||
public: | ||
F(wchar_t *); | ||
}; | ||
using a = F; | ||
struct A {}; | ||
struct b { | ||
b(a, F, A); | ||
}; | ||
template <typename, typename> struct c : b { | ||
c(const a &p1, const A &d) : b(p1, 0, d) {} | ||
}; | ||
template <typename e> struct B : c<e, b> { | ||
using c<e, b>::c; | ||
}; | ||
class f { | ||
public: | ||
f(...); | ||
} | ||
|
||
typedef g; | ||
class C { | ||
public: | ||
C(g, f); | ||
}; | ||
static wchar_t h; | ||
class D { | ||
public: | ||
static C E(); | ||
}; | ||
|
||
C D::E() { | ||
C i(B<bool>(&h, {}), f()); | ||
return i; | ||
} | ||
|
||
// Inheriting ctor has internal linkage without comdat. | ||
|
||
// CHECK-LABEL: define internal noundef ptr @"??0?$B@_N@@QEAA@AEBVF@@AEBUA@@@Z" | ||
// CHECK-NOT:comdat | ||
// CHECK-SAME: {{\{$}} | ||
|
||
// non-inheriting ctro should has linkonce_odr with comdat attribute. | ||
|
||
// CHECK-LABEL: define linkonce_odr dso_local noundef ptr @"??0?$c@_NUb@@@@QEAA@AEBVF@@AEBUA@@@Z" | ||
// CHECK:comdat | ||
// CHECK-SAME: {{\{$}} |