Skip to content

Commit

Permalink
[ASTImporter] Enable disabled but passing tests
Browse files Browse the repository at this point in the history
Reviewers: a_sidorin, a.sidorin, shafik

Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D62066

llvm-svn: 361139
  • Loading branch information
Gabor Marton committed May 20, 2019
1 parent 11fa0ee commit 1d51e3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
13 changes: 2 additions & 11 deletions clang/unittests/AST/ASTImporterTest.cpp
Expand Up @@ -2362,12 +2362,7 @@ TEST_P(ImportFriendFunctions,
EXPECT_EQ(ToFD->getPreviousDecl(), ImportedD);
}

// Disabled temporarily, because the new structural equivalence check
// (https://reviews.llvm.org/D48628) breaks it.
// PreviousDecl is not set because there is no structural match.
// FIXME Enable!
TEST_P(ImportFriendFunctions,
DISABLED_ImportFriendFunctionRedeclChainDefWithClass) {
TEST_P(ImportFriendFunctions, ImportFriendFunctionRedeclChainDefWithClass) {
auto Pattern = functionDecl(hasName("f"));

Decl *FromTU = getTuDecl(
Expand Down Expand Up @@ -2395,12 +2390,8 @@ TEST_P(ImportFriendFunctions,
(*ImportedD->param_begin())->getOriginalType());
}

// Disabled temporarily, because the new structural equivalence check
// (https://reviews.llvm.org/D48628) breaks it.
// PreviousDecl is not set because there is no structural match.
// FIXME Enable!
TEST_P(ImportFriendFunctions,
DISABLED_ImportFriendFunctionRedeclChainDefWithClass_ImportTheProto) {
ImportFriendFunctionRedeclChainDefWithClass_ImportTheProto) {
auto Pattern = functionDecl(hasName("f"));

Decl *FromTU = getTuDecl(
Expand Down
3 changes: 1 addition & 2 deletions clang/unittests/AST/StructuralEquivalenceTest.cpp
Expand Up @@ -300,8 +300,7 @@ TEST_F(StructuralEquivalenceFunctionTest, ThrowVsNoexceptTrue) {
EXPECT_FALSE(testStructuralMatch(t));
}

TEST_F(StructuralEquivalenceFunctionTest, DISABLED_NoexceptNonMatch) {
// The expression is not checked yet.
TEST_F(StructuralEquivalenceFunctionTest, NoexceptNonMatch) {
auto t = makeNamedDecls("void foo() noexcept(false);",
"void foo() noexcept(true);", Lang_CXX11);
EXPECT_FALSE(testStructuralMatch(t));
Expand Down

0 comments on commit 1d51e3e

Please sign in to comment.