Skip to content

Commit

Permalink
[Symbolizer] Move ctor/dtor into .cpp file
Browse files Browse the repository at this point in the history
On some standard library configurations these have a dependency on the
complete type of SymbolizableModule. They also do a lot of
copying/freeing so no point in inlining them.
  • Loading branch information
d0k committed Feb 24, 2022
1 parent 5146067 commit 1e396af
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
Expand Up @@ -61,9 +61,9 @@ class LLVMSymbolizer {
};

LLVMSymbolizer() = default;
LLVMSymbolizer(const Options &Opts) : Opts(Opts) {}
LLVMSymbolizer(const Options &Opts);

~LLVMSymbolizer() { flush(); }
~LLVMSymbolizer();

// Overloads accepting ObjectFile does not support COFF currently
Expected<DILineInfo> symbolizeCode(const ObjectFile &Obj,
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
Expand Up @@ -39,6 +39,10 @@
namespace llvm {
namespace symbolize {

LLVMSymbolizer::LLVMSymbolizer(const Options &Opts) : Opts(Opts) {}

LLVMSymbolizer::~LLVMSymbolizer() = default;

template <typename T>
Expected<DILineInfo>
LLVMSymbolizer::symbolizeCodeCommon(const T &ModuleSpecifier,
Expand Down

0 comments on commit 1e396af

Please sign in to comment.