Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ELF: Move sections referred to by __start_/__stop_ symbols into the m…
…ain partition. In the case where C identifier sections have SHF_LINK_ORDER they will most likely be placed in the same partition as the section that they are associated with. But unless this happens to be the main partition, this will cause them to be excluded from the range covered by the __start_ and __stop_ symbols, which may lead to incorrect program behaviour. So we need to move them all into the main partition so that they will be covered by the __start_ and __stop_ symbols. We may want to refine this approach later and allow different __start_/__stop_ symbol values for different partitions. This would only make sense for relocations from SHT_NOTE sections since they are duplicated into each partition. Differential Revision: https://reviews.llvm.org/D65909 llvm-svn: 368375
- Loading branch information
Showing
2 changed files
with
55 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// REQUIRES: x86 | ||
// RUN: llvm-mc %s -o %t.o -filetype=obj --triple=x86_64-unknown-linux | ||
// RUN: ld.lld %t.o -o %t --export-dynamic --gc-sections | ||
// RUN: llvm-readelf -S %t | FileCheck --implicit-check-not=has_startstop %s | ||
|
||
// We can't let the has_startstop section be split by partition because it is | ||
// referenced by __start_ and __stop_ symbols, so the split could result in | ||
// some sections being moved out of the __start_/__stop_ range. Make sure that | ||
// that didn't happen by checking that there is only one section. | ||
// | ||
// It's fine for us to split no_startstop because of the lack of | ||
// __start_/__stop_ symbols. | ||
|
||
// CHECK: has_startstop | ||
// CHECK: no_startstop | ||
|
||
// CHECK: no_startstop | ||
|
||
.section .llvm_sympart.f1,"",@llvm_sympart | ||
.asciz "part1" | ||
.quad f1 | ||
|
||
.section .text._start,"ax",@progbits | ||
.globl _start | ||
_start: | ||
call __start_has_startstop | ||
call __stop_has_startstop | ||
|
||
.section .text.f1,"ax",@progbits | ||
.globl f1 | ||
f1: | ||
|
||
.section has_startstop,"ao",@progbits,.text._start,unique,1 | ||
.quad 1 | ||
|
||
.section has_startstop,"ao",@progbits,.text.f1,unique,2 | ||
.quad 2 | ||
|
||
.section no_startstop,"ao",@progbits,.text._start,unique,1 | ||
.quad 3 | ||
|
||
.section no_startstop,"ao",@progbits,.text.f1,unique,2 | ||
.quad 4 |