-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hwasan: Untag unwound stack frames by wrapping personality functions.
One problem with untagging memory in landing pads is that it only works correctly if the function that catches the exception is instrumented. If the function is uninstrumented, we have no opportunity to untag the memory. To address this, replace landing pad instrumentation with personality function wrapping. Each function with an instrumented stack has its personality function replaced with a wrapper provided by the runtime. Functions that did not have a personality function to begin with also get wrappers if they may be unwound past. As the unwinder calls personality functions during stack unwinding, the original personality function is called and the function's stack frame is untagged by the wrapper if the personality function instructs the unwinder to keep unwinding. If unwinding stops at a landing pad, the function is still responsible for untagging its stack frame if it resumes unwinding. The old landing pad mechanism is preserved for compatibility with old runtimes. Differential Revision: https://reviews.llvm.org/D66377 llvm-svn: 369721
- Loading branch information
Showing
8 changed files
with
277 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
//===-- hwasan_exceptions.cpp ---------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This file is a part of HWAddressSanitizer. | ||
// | ||
// HWAddressSanitizer runtime. | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "hwasan_poisoning.h" | ||
#include "sanitizer_common/sanitizer_common.h" | ||
|
||
#include <unwind.h> | ||
|
||
using namespace __hwasan; | ||
using namespace __sanitizer; | ||
|
||
typedef _Unwind_Reason_Code PersonalityFn(int version, _Unwind_Action actions, | ||
uint64_t exception_class, | ||
_Unwind_Exception* unwind_exception, | ||
_Unwind_Context* context); | ||
|
||
// Pointers to the _Unwind_GetGR and _Unwind_GetCFA functions are passed in | ||
// instead of being called directly. This is to handle cases where the unwinder | ||
// is statically linked and the sanitizer runtime and the program are linked | ||
// against different unwinders. The _Unwind_Context data structure is opaque so | ||
// it may be incompatible between unwinders. | ||
typedef _Unwind_Word GetGRFn(_Unwind_Context* context, int index); | ||
typedef _Unwind_Word GetCFAFn(_Unwind_Context* context); | ||
|
||
extern "C" _Unwind_Reason_Code __hwasan_personality_wrapper( | ||
int version, _Unwind_Action actions, uint64_t exception_class, | ||
_Unwind_Exception* unwind_exception, _Unwind_Context* context, | ||
PersonalityFn* real_personality, GetGRFn* get_gr, GetCFAFn* get_cfa) { | ||
_Unwind_Reason_Code rc; | ||
if (real_personality) | ||
rc = real_personality(version, actions, exception_class, unwind_exception, | ||
context); | ||
else | ||
rc = _URC_CONTINUE_UNWIND; | ||
|
||
// We only untag frames without a landing pad because landing pads are | ||
// responsible for untagging the stack themselves if they resume. | ||
// | ||
// Here we assume that the frame record appears after any locals. This is not | ||
// required by AAPCS but is a requirement for HWASAN instrumented functions. | ||
if ((actions & _UA_CLEANUP_PHASE) && rc == _URC_CONTINUE_UNWIND) { | ||
#if defined(__x86_64__) | ||
uptr fp = get_gr(context, 6); // rbp | ||
#elif defined(__aarch64__) | ||
uptr fp = get_gr(context, 29); // x29 | ||
#else | ||
#error Unsupported architecture | ||
#endif | ||
uptr sp = get_cfa(context); | ||
TagMemory(sp, fp - sp, 0); | ||
} | ||
|
||
return rc; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.