Skip to content

Commit

Permalink
[InstCombine] Pre-land tests for maximum(a,b) +* minimum(a,b) => a +* b
Browse files Browse the repository at this point in the history
  • Loading branch information
Serguei Katkov committed Apr 4, 2023
1 parent 39eb7ae commit 22b8edc
Show file tree
Hide file tree
Showing 2 changed files with 225 additions and 0 deletions.
112 changes: 112 additions & 0 deletions llvm/test/Transforms/InstCombine/fadd-maximum-minimum.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s

declare float @llvm.minimum.f32(float %Val0, float %Val1)
declare float @llvm.maximum.f32(float %Val0, float %Val1)
declare <4 x float> @llvm.minimum.v4f32(<4 x float> %Val0, <4 x float> %Val1)
declare <4 x float> @llvm.maximum.v4f32(<4 x float> %Val0, <4 x float> %Val1)

define float @test(float %a, float %b) {
; CHECK-LABEL: @test(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fadd float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fadd float %min, %max
ret float %res
}

define float @test_comm1(float %a, float %b) {
; CHECK-LABEL: @test_comm1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fadd float [[MAX]], [[MIN]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fadd float %max, %min
ret float %res
}

define float @test_comm2(float %a, float %b) {
; CHECK-LABEL: @test_comm2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[B]], float [[A]])
; CHECK-NEXT: [[RES:%.*]] = fadd float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %b, float %a)
%res = fadd float %min, %max
ret float %res
}

define float @test_comm3(float %a, float %b) {
; CHECK-LABEL: @test_comm3(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[B]], float [[A]])
; CHECK-NEXT: [[RES:%.*]] = fadd float [[MAX]], [[MIN]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %b, float %a)
%res = fadd float %max, %min
ret float %res
}

define <4 x float> @test_vect(<4 x float> %a, <4 x float> %b) {
; CHECK-LABEL: @test_vect(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call <4 x float> @llvm.minimum.v4f32(<4 x float> [[A:%.*]], <4 x float> [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call <4 x float> @llvm.maximum.v4f32(<4 x float> [[B]], <4 x float> [[A]])
; CHECK-NEXT: [[RES:%.*]] = fadd <4 x float> [[MIN]], [[MAX]]
; CHECK-NEXT: ret <4 x float> [[RES]]
;
entry:
%min = call <4 x float> @llvm.minimum.v4f32(<4 x float> %a, <4 x float> %b)
%max = call <4 x float> @llvm.maximum.v4f32(<4 x float> %b, <4 x float> %a)
%res = fadd <4 x float> %min, %max
ret <4 x float> %res
}

define float @test_flags(float %a, float %b) {
; CHECK-LABEL: @test_flags(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fadd fast float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fadd fast float %min, %max
ret float %res
}

define float @test_flags2(float %a, float %b) {
; CHECK-LABEL: @test_flags2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fadd reassoc ninf nsz arcp contract afn float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fadd reassoc ninf nsz arcp contract afn float %min, %max
ret float %res
}
113 changes: 113 additions & 0 deletions llvm/test/Transforms/InstCombine/fmul-maximum-minimum.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s

declare float @llvm.minimum.f32(float %Val0, float %Val1)
declare float @llvm.maximum.f32(float %Val0, float %Val1)
declare <4 x float> @llvm.minimum.v4f32(<4 x float> %Val0, <4 x float> %Val1)
declare <4 x float> @llvm.maximum.v4f32(<4 x float> %Val0, <4 x float> %Val1)

define float @test(float %a, float %b) {
; CHECK-LABEL: @test(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fmul float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fmul float %min, %max
ret float %res
}

define float @test_comm1(float %a, float %b) {
; CHECK-LABEL: @test_comm1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fmul float [[MAX]], [[MIN]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fmul float %max, %min
ret float %res
}

define float @test_comm2(float %a, float %b) {
; CHECK-LABEL: @test_comm2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[B]], float [[A]])
; CHECK-NEXT: [[RES:%.*]] = fmul float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %b, float %a)
%res = fmul float %min, %max
ret float %res
}


define float @test_comm3(float %a, float %b) {
; CHECK-LABEL: @test_comm3(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[B]], float [[A]])
; CHECK-NEXT: [[RES:%.*]] = fmul float [[MAX]], [[MIN]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %b, float %a)
%res = fmul float %max, %min
ret float %res
}

define <4 x float> @test_vect(<4 x float> %a, <4 x float> %b) {
; CHECK-LABEL: @test_vect(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call <4 x float> @llvm.minimum.v4f32(<4 x float> [[A:%.*]], <4 x float> [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call <4 x float> @llvm.maximum.v4f32(<4 x float> [[B]], <4 x float> [[A]])
; CHECK-NEXT: [[RES:%.*]] = fmul <4 x float> [[MIN]], [[MAX]]
; CHECK-NEXT: ret <4 x float> [[RES]]
;
entry:
%min = call <4 x float> @llvm.minimum.v4f32(<4 x float> %a, <4 x float> %b)
%max = call <4 x float> @llvm.maximum.v4f32(<4 x float> %b, <4 x float> %a)
%res = fmul <4 x float> %min, %max
ret <4 x float> %res
}

define float @test_flags(float %a, float %b) {
; CHECK-LABEL: @test_flags(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fmul fast float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fmul fast float %min, %max
ret float %res
}

define float @test_flags2(float %a, float %b) {
; CHECK-LABEL: @test_flags2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call float @llvm.minimum.f32(float [[A:%.*]], float [[B:%.*]])
; CHECK-NEXT: [[MAX:%.*]] = call float @llvm.maximum.f32(float [[A]], float [[B]])
; CHECK-NEXT: [[RES:%.*]] = fmul reassoc ninf nsz arcp contract afn float [[MIN]], [[MAX]]
; CHECK-NEXT: ret float [[RES]]
;
entry:
%min = call float @llvm.minimum.f32(float %a, float %b)
%max = call float @llvm.maximum.f32(float %a, float %b)
%res = fmul reassoc ninf nsz arcp contract afn float %min, %max
ret float %res
}

0 comments on commit 22b8edc

Please sign in to comment.