Skip to content

Commit

Permalink
[NFC][sanitizer] Fix veradic-macro warning in RAW_CHECK
Browse files Browse the repository at this point in the history
  • Loading branch information
vitalybuka committed Nov 18, 2021
1 parent 1ce77b5 commit 254f931
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h
Expand Up @@ -300,7 +300,8 @@ void NORETURN CheckFailed(const char *file, int line, const char *cond,
} \
} while (0)

#define RAW_CHECK(expr, ...) RAW_CHECK_MSG(expr, #expr "\n", __VA_ARGS__)
#define RAW_CHECK(expr) RAW_CHECK_MSG(expr, #expr "\n", )
#define RAW_CHECK_VA(expr, ...) RAW_CHECK_MSG(expr, #expr "\n", __VA_ARGS__)

#define CHECK_IMPL(c1, op, c2) \
do { \
Expand Down
10 changes: 5 additions & 5 deletions compiler-rt/lib/sanitizer_common/sanitizer_printf.cpp
Expand Up @@ -191,30 +191,30 @@ int VSNPrintf(char *buff, int buff_length,
break;
}
case 'p': {
RAW_CHECK(!have_flags, kPrintfFormatsHelp, format);
RAW_CHECK_VA(!have_flags, kPrintfFormatsHelp, format);
result += AppendPointer(&buff, buff_end, va_arg(args, uptr));
break;
}
case 's': {
RAW_CHECK(!have_length, kPrintfFormatsHelp, format);
RAW_CHECK_VA(!have_length, kPrintfFormatsHelp, format);
// Only left-justified width is supported.
CHECK(!have_width || left_justified);
result += AppendString(&buff, buff_end, left_justified ? -width : width,
precision, va_arg(args, char*));
break;
}
case 'c': {
RAW_CHECK(!have_flags, kPrintfFormatsHelp, format);
RAW_CHECK_VA(!have_flags, kPrintfFormatsHelp, format);
result += AppendChar(&buff, buff_end, va_arg(args, int));
break;
}
case '%' : {
RAW_CHECK(!have_flags, kPrintfFormatsHelp, format);
RAW_CHECK_VA(!have_flags, kPrintfFormatsHelp, format);
result += AppendChar(&buff, buff_end, '%');
break;
}
default: {
RAW_CHECK(false, kPrintfFormatsHelp, format);
RAW_CHECK_VA(false, kPrintfFormatsHelp, format);
}
}
}
Expand Down

0 comments on commit 254f931

Please sign in to comment.