Skip to content

Commit

Permalink
[Dexter] Remove builder from Dexter
Browse files Browse the repository at this point in the history
See "discussion":
  https://discourse.llvm.org/t/rfc-dexter-feature-removals/60462

This patch removes the builder functionality from Dexter, as it is an active
maintenance burden and is no longer required since Dexter is being invoked by
other test runners that can handle the build step better, and there has been no
objection that it is still needed.

Differential Revision: https://reviews.llvm.org/D151465
  • Loading branch information
SLTozer committed Aug 21, 2023
1 parent 3bcce9c commit 262520a
Show file tree
Hide file tree
Showing 129 changed files with 286 additions and 495 deletions.
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows
//
// RUN: %clang -O0 -g -lstdc++ %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' --cflags "-O0 -g" \
// RUN: --ldflags="-lstdc++" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
// Radar 8945514

class SVal {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@
// lldb-8, even outside of dexter, will sometimes trigger an asan fault in
// the debugged process and generally freak out.

// RUN: %clang -O1 -glldb -fsanitize=address -arch x86_64 %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-O1 -glldb -fsanitize=address -arch x86_64" \
// RUN: --ldflags="-fsanitize=address" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
#include <deque>

struct A {
Expand Down
6 changes: 3 additions & 3 deletions cross-project-tests/debuginfo-tests/dexter-tests/asan.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
// Zorg configures the ASAN stage2 bots to not build the asan
// compiler-rt. Only run this test on non-asanified configurations.
//
// RUN: %clang --driver-mode=gcc -O0 -glldb -fblocks -arch x86_64 \
// RUN: -fsanitize=address %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang-c' --debugger 'lldb' \
// RUN: --cflags "--driver-mode=gcc -O0 -glldb -fblocks -arch x86_64 \
// RUN: -fsanitize=address" --ldflags="-fsanitize=address" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

struct S {
int a[8];
Expand Down
3 changes: 2 additions & 1 deletion cross-project-tests/debuginfo-tests/dexter-tests/ctor.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows
//
// RUN: %clang -O0 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' --cflags "-O0 -glldb" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

class A {
public:
Expand Down
4 changes: 2 additions & 2 deletions cross-project-tests/debuginfo-tests/dexter-tests/dbg-arg.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// UNSUPPORTED: system-windows
//
// This test case checks debug info during register moves for an argument.
// RUN: %clang -m64 -mllvm -fast-isel=false -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder clang-c --debugger 'lldb' \
// RUN: --cflags "-m64 -mllvm -fast-isel=false -g" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
//
// Radar 8412415

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows

// RUN: %clang -O0 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-g -O0" -v -- %s
// RUN: --binary %t --debugger 'lldb' -v -- %s

const int d = 100;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w --builder 'clang-cl_vs2015' \
// RUN: --debugger 'dbgeng' --cflags '/Z7 /Zi' --ldflags '/Z7 /Zi' -- %s
// RUN: %clang-cl /Z7 /Zi %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s

// Check that global constants have debug info.

Expand Down
4 changes: 2 additions & 2 deletions cross-project-tests/debuginfo-tests/dexter-tests/hello.c
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w --builder 'clang-cl_vs2015' \
// RUN: --debugger 'dbgeng' --cflags '/Z7 /Zi' --ldflags '/Z7 /Zi' -- %s
// RUN: %clang-cl /Z7 /Zi %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s

#include <stdio.h>
int main() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
// REQUIRES: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w --builder 'clang-cl_vs2015' \
// RUN: --debugger 'dbgeng' --cflags '/Od /Z7 /Zi' \
// RUN: --ldflags '/Od /Z7 /Zi' -- %s
// RUN: %clang-cl /Od /Z7 /Zi %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s
//
// RUN: %dexter --fail-lt 1.0 -w --builder 'clang-cl_vs2015' \
// RUN: --debugger 'dbgeng' --cflags '/O2 /Z7 /Zi' \
// RUN: --ldflags '/O2 /Z7 /Zi' -- %s
// RUN: %clang-cl /O2 /Z7 /Zi %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t \
// RUN: --debugger 'dbgeng' -- %s

// This code is structured to have an early exit with an epilogue in the middle
// of the function, which creates a gap between the beginning of the inlined
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

//// Adapted from https://bugs.llvm.org/show_bug.cgi?id=34136#c1
//// LowerDbgDeclare has since been updated to look through bitcasts. We still
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

//// Adapted from https://bugs.llvm.org/show_bug.cgi?id=34136#c4

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder clang-c --cflags "-O2 -glldb" -- %s
// RUN: %clang -O2 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

//// Check that we give good locations to a variable ('local') which is escaped
//// down some control paths and not others. This example is handled well currently.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

//// Check that 'param' in 'fun' can be read throughout, and that 'pa' and 'pb'
//// can be dereferenced in the debugger even if we can't provide the pointer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

// 1. param is escaped by inlineme(&param) so it is not promoted by
// SROA/mem2reg.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder clang-c --cflags "-O2 -glldb" -- %s
// RUN: %clang -O2 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
//
//// Check that once-escaped variable 'param' can still be read after we
//// perform inlining + mem2reg, and that we see the DSE'd value 255.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder clang-c --cflags "-O2 -glldb" -- %s
// RUN: %clang -O2 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
//
//// Check that the once-escaped variable 'param' can still be read after
//// we perform inlining + mem2reg. See D89810 and D85555.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

//// Check that escaped local 'param' in function 'fun' has sensible debug info
//// after the escaping function 'use' gets arg promotion (int* -> int). Currently
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s

// 1. parama is escaped by esc(&parama) so it is not promoted by
// SROA/mem2reg.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder clang-c --cflags "-O2 -glldb" -- %s
// RUN: %clang -O2 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
//
//// Check that a pointer to a variable living on the stack dereferences to the
//// variable value.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb \
// RUN: --builder clang-c --cflags "-O2 -glldb" -- %s
// RUN: %clang -O2 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --debugger lldb --binary %t -- %s
//
//// Check debug-info for the escaped struct variable num is reasonable.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

// REQUIRES: lldb
// UNSUPPORTED: system-windows
// RUN: %dexter --fail-lt 0.1 -w --debugger lldb \
// RUN: --builder 'clang-c' --cflags "-O3 -glldb" -- %s
// RUN: %clang -O3 -glldb %s -o %t
// RUN: %dexter --fail-lt 0.1 -w --debugger lldb --binary %t -- %s
// See NOTE at end for more info about the RUN command.

// 1. SROA/mem2reg fully promotes parama.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows

// RUN: %clang -g -O0 %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-g -O0" -v -- %s
// RUN: --binary %t --debugger 'lldb' -v -- %s

#include <stdio.h>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
// Zorg configures the ASAN stage2 bots to not build the asan
// compiler-rt. Only run this test on non-asanified configurations.
//
// RUN: %clang -O0 -glldb -fno-exceptions %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-O0 -glldb -fno-exceptions" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
//
// RUN: %clang -O1 -glldb -fno-exceptions %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-O1 -glldb -fno-exceptions" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
//
// PR34513
volatile int sideeffect = 0;
Expand Down
4 changes: 2 additions & 2 deletions cross-project-tests/debuginfo-tests/dexter-tests/nrvo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
//
// REQUIRES: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w --builder 'clang-cl_vs2015' \
// RUN: --debugger 'dbgeng' --cflags '/Z7 /Zi' --ldflags '/Z7 /Zi' -- %s
// RUN: %clang-cl /Z7 /Zi %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s

struct string {
string() {}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// RUN: %clang -O2 -ffast-math -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-ffast-math -O2 -g" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
// RUN: %clang -O0 -ffast-math -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-ffast-math -O0 -g" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

// REQUIRES: lldb
// UNSUPPORTED: system-windows
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
// UNSUPPORTED: system-windows
// UNSUPPORTED: system-darwin

// RUN: %clang -O2 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-O2 -g" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

// A simple loop of assignments.
// With optimization level > 0 the compiler reorders basic blocks
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// RUN: %clang -O2 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-O2 -g" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s
// RUN: %clang -O0 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-O0 -g" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

// REQUIRES: lldb, D136396
// UNSUPPORTED: system-windows
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// RUN: %clang++ -O2 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-g -O2" -v -- %s
// RUN: --binary %t --debugger 'lldb' -v -- %s
// RUN: %clang++ -O0 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-g -O0" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

// REQUIRES: lldb
// UNSUPPORTED: system-windows
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// RUN: %clang -O2 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-g -O2" -v -- %s
// RUN: --binary %t --debugger 'lldb' -v -- %s
// RUN: %clang -O0 -g %s -o %t
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder 'clang' --debugger 'lldb' \
// RUN: --cflags "-g -O0" -- %s
// RUN: --binary %t --debugger 'lldb' -- %s

// REQUIRES: lldb
// UNSUPPORTED: system-windows
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w --builder 'clang-cl_vs2015' \
// RUN: --debugger 'dbgeng' --cflags '/Z7 /Zi' --ldflags '/Z7 /Zi' -- %s
// RUN: %clang-cl /Z7 /Zi %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s

// From https://llvm.org/pr38857, where we had issues with stack realignment.

Expand Down
4 changes: 2 additions & 2 deletions cross-project-tests/debuginfo-tests/dexter-tests/stack-var.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder clang-c --debugger 'lldb' --cflags "-O -glldb" -- %s
// RUN: %clang -O -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'lldb' -- %s

void __attribute__((noinline, optnone)) bar(int *test) {}
int main() {
Expand Down
4 changes: 2 additions & 2 deletions cross-project-tests/debuginfo-tests/dexter-tests/vla.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// REQUIRES: lldb
// UNSUPPORTED: system-windows
//
// RUN: %dexter --fail-lt 1.0 -w \
// RUN: --builder clang-c --debugger 'lldb' --cflags "-O0 -glldb" -- %s
// RUN: %clang -O0 -glldb %s -o %t
// RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'lldb' -- %s

void init_vla(int size) {
int i;
Expand Down

0 comments on commit 262520a

Please sign in to comment.