Skip to content

Commit

Permalink
[InstrProf] Fix warning about converting double to float
Browse files Browse the repository at this point in the history
In https://reviews.llvm.org/D147812 I introduced the class
`BalancedPartitioning` and it seemed to trigger a warning in flang

```
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\include\llvm/Support/BalancedPartitioning.h(89): warning C4305: 'initializing': truncation from 'double' to 'float'
```

For good measure, I converted all double literals to floats. This should
be a NFC.
  • Loading branch information
ellishg committed Jun 6, 2023
1 parent 8aad501 commit 266ffd7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion llvm/include/llvm/Support/BalancedPartitioning.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ struct BalancedPartitioningConfig {
unsigned IterationsPerSplit = 40;
/// The probability for a vertex to skip a move from its current bucket to
/// another bucket; it often helps to escape from a local optima
float SkipProbability = 0.1;
float SkipProbability = 0.1f;
/// Recursive subtasks up to the given depth are added to the queue and
/// distributed among threads by ThreadPool; all subsequent calls are executed
/// on the same thread
Expand Down
10 changes: 5 additions & 5 deletions llvm/lib/Support/BalancedPartitioning.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ unsigned BalancedPartitioning::runIteration(const FunctionNodeRange Nodes,
unsigned R = Signature.RightCount;
assert((L > 0 || R > 0) && "incorrect signature");
float Cost = logCost(L, R);
Signature.CachedGainLR = 0;
Signature.CachedGainRL = 0;
Signature.CachedGainLR = 0.f;
Signature.CachedGainRL = 0.f;
if (L > 0)
Signature.CachedGainLR = Cost - logCost(L - 1, R + 1);
if (R > 0)
Expand Down Expand Up @@ -247,7 +247,7 @@ unsigned BalancedPartitioning::runIteration(const FunctionNodeRange Nodes,
auto &[LeftGain, LeftNode] = LeftPair;
auto &[RightGain, RightNode] = RightPair;
// Stop when the gain is no longer beneficial
if (LeftGain + RightGain <= 0.0)
if (LeftGain + RightGain <= 0.f)
break;
// Try to exchange the nodes between buckets
if (moveFunctionNode(*LeftNode, LeftBucket, RightBucket, Signatures, RNG))
Expand All @@ -264,7 +264,7 @@ bool BalancedPartitioning::moveFunctionNode(BPFunctionNode &N,
SignaturesT &Signatures,
std::mt19937 &RNG) const {
// Sometimes we skip the move. This helps to escape local optima
if (std::uniform_real_distribution<float>(0.0, 1.0)(RNG) <=
if (std::uniform_real_distribution<float>(0.f, 1.f)(RNG) <=
Config.SkipProbability)
return false;

Expand Down Expand Up @@ -309,7 +309,7 @@ void BalancedPartitioning::split(const FunctionNodeRange Nodes,
float BalancedPartitioning::moveGain(const BPFunctionNode &N,
bool FromLeftToRight,
const SignaturesT &Signatures) {
float Gain = 0;
float Gain = 0.f;
for (auto &UN : N.UtilityNodes)
Gain += (FromLeftToRight ? Signatures[UN].CachedGainLR
: Signatures[UN].CachedGainRL);
Expand Down

0 comments on commit 266ffd7

Please sign in to comment.