Skip to content

Commit

Permalink
[llvm-objcopy] - Remove dead code. NFCI.
Browse files Browse the repository at this point in the history
DecompressedSection can only be created if --decompress-debug-sections is specified.
https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-objcopy/ELF/ELFObjcopy.cpp#L492

If it is specified when !zlib::isAvailable(), we error out early when parsing the options:
https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-objcopy/CopyConfig.cpp#L657

What means the code I am removing in this patch is dead.

Differential revision: https://reviews.llvm.org/D59017

llvm-svn: 355505
  • Loading branch information
George Rimar committed Mar 6, 2019
1 parent 89eb7bb commit 281a5be
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions llvm/tools/llvm-objcopy/ELF/Object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,6 @@ getDecompressedSizeAndAlignment(ArrayRef<uint8_t> Data) {

template <class ELFT>
void ELFSectionWriter<ELFT>::visit(const DecompressedSection &Sec) {
uint8_t *Buf = Out.getBufferStart() + Sec.Offset;

if (!zlib::isAvailable()) {
std::copy(Sec.OriginalData.begin(), Sec.OriginalData.end(), Buf);
return;
}

const size_t DataOffset = isDataGnuCompressed(Sec.OriginalData)
? (ZlibGnuMagic.size() + sizeof(Sec.Size))
: sizeof(Elf_Chdr_Impl<ELFT>);
Expand All @@ -202,6 +195,7 @@ void ELFSectionWriter<ELFT>::visit(const DecompressedSection &Sec) {
static_cast<size_t>(Sec.Size)))
reportError(Sec.Name, std::move(E));

uint8_t *Buf = Out.getBufferStart() + Sec.Offset;
std::copy(DecompressedContent.begin(), DecompressedContent.end(), Buf);
}

Expand Down

0 comments on commit 281a5be

Please sign in to comment.