Skip to content

Commit

Permalink
Revert "Reland "[Win32][ELF] Make CodeView a DebugInfoFormat only for…
Browse files Browse the repository at this point in the history
… COFF format" (#87987)"

This reverts commit 4a93872.

Sorry, there're still buildbot failures.
  • Loading branch information
phoebewang committed Apr 10, 2024
1 parent 469caa3 commit 299b636
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
5 changes: 3 additions & 2 deletions clang/lib/Driver/ToolChains/MSVC.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,9 @@ class LLVM_LIBRARY_VISIBILITY MSVCToolChain : public ToolChain {
/// formats, and to DWARF otherwise. Users can use -gcodeview and -gdwarf to
/// override the default.
llvm::codegenoptions::DebugInfoFormat getDefaultDebugFormat() const override {
return getTriple().isOSBinFormatCOFF() ? llvm::codegenoptions::DIF_CodeView
: llvm::codegenoptions::DIF_DWARF;
return getTriple().isOSBinFormatMachO()
? llvm::codegenoptions::DIF_DWARF
: llvm::codegenoptions::DIF_CodeView;
}

/// Set the debugger tuning to "default", since we're definitely not tuning
Expand Down
1 change: 0 additions & 1 deletion clang/test/Driver/gcodeview-command-line.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Note: %s must be preceded by --, otherwise it may be interpreted as a
// command-line option, e.g. on Mac where %s is commonly under /Users.
// REQUIRES: aarch64-registered-target,arm-registered-target,x86-registered-target

// ON-NOT: "-gno-codview-commandline"
// OFF: "-gno-codeview-command-line"
Expand Down
5 changes: 0 additions & 5 deletions clang/test/Misc/win32-elf.c

This file was deleted.

0 comments on commit 299b636

Please sign in to comment.