Skip to content

Commit

Permalink
[lldb] Make TestModuleLoadedNotifys work with dyld from the shared cache
Browse files Browse the repository at this point in the history
Make TestModuleLoadedNotifys work with a dyld from the expanded shared
cache in the DeviceSupport directory. In that case the module path is:

  ~/Library/Developer/Xcode/iOS DeviceSupport/<...>/Symbols/usr/lib/dyld

instead of just:

  /usr/lib/dyld

This makes the test pass when running against an embedded Darwin device.
  • Loading branch information
JDevlieghere committed Aug 3, 2022
1 parent 880b212 commit 2b61b77
Showing 1 changed file with 4 additions and 2 deletions.
Expand Up @@ -82,8 +82,10 @@ def test_launch_notifications(self):
module = lldb.SBTarget.GetModuleAtIndexFromEvent(i, event)
# On macOS Ventura and later, dyld and the main binary
# will be loaded again when dyld moves itself into the
# shared cache.
if module.file.fullpath not in ['/usr/lib/dyld', exe]:
# shared cache. Use the basename so this also works
# when reading dyld from the expanded shared cache.
exe_basename = lldb.SBFileSpec(exe).basename
if module.file.basename not in ['dyld', exe_basename]:
self.assertTrue(module not in already_loaded_modules, '{} is already loaded'.format(module))
already_loaded_modules.append(module)
if self.TraceOn():
Expand Down

0 comments on commit 2b61b77

Please sign in to comment.