-
Notifications
You must be signed in to change notification settings - Fork 11k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[XCOFF] Force recording a relocation for weak symbol label.
Summary: Currently, if there are multiple definitions of the same symbol declared has weak linkage, the linker may choose the wrong one when they are compiled with integrated-as. This patch fixes the issue. If the target symbol is a weak label we must not attempt to resolve the fixup directly. Emit a relocation and leave resolution of the final target address to the linker. Reviewed By: shchenz Differential Revision: https://reviews.llvm.org/D153839
- Loading branch information
Showing
3 changed files
with
55 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s | ||
; RUN: llvm-objdump -dr %t.o | FileCheck --check-prefix=OBJ32 %s | ||
|
||
; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -filetype=obj -o %t.o < %s | ||
; RUN: llvm-objdump -dr %t.o | FileCheck --check-prefix=OBJ64 %s | ||
|
||
; Function Attrs: noinline nounwind optnone | ||
define i32 @main() { | ||
entry: | ||
%retval = alloca i32, align 4 | ||
store i32 0, ptr %retval, align 4 | ||
%call = call i32 @foo() | ||
ret i32 %call | ||
} | ||
|
||
; Function Attrs: noinline nounwind optnone | ||
define weak i32 @foo() { | ||
entry: | ||
ret i32 3 | ||
} | ||
|
||
; OBJ32: 00000000 <.main>: | ||
; OBJ32-NEXT: 0: 7c 08 02 a6 mflr 0 | ||
; OBJ32-NEXT: 4: 94 21 ff c0 stwu 1, -64(1) | ||
; OBJ32-NEXT: 8: 38 60 00 00 li 3, 0 | ||
; OBJ32-NEXT: c: 90 01 00 48 stw 0, 72(1) | ||
; OBJ32-NEXT: 10: 90 61 00 3c stw 3, 60(1) | ||
; OBJ32-NEXT: 14: 48 00 00 31 bl 0x44 <.foo> | ||
; OBJ32-NEXT: 00000014: R_RBR .foo | ||
; OBJ32-NEXT: 18: 60 00 00 00 nop | ||
; OBJ32: 00000044 <.foo>: | ||
; OBJ32-NEXT: 44: 38 60 00 03 li 3, 3 | ||
; OBJ32-NEXT: 48: 4e 80 00 20 blr | ||
|
||
; OBJ64: 0000000000000000 <.main>: | ||
; OBJ64-NEXT: 0: 7c 08 02 a6 mflr 0 | ||
; OBJ64-NEXT: 4: f8 21 ff 81 stdu 1, -128(1) | ||
; OBJ64-NEXT: 8: 38 60 00 00 li 3, 0 | ||
; OBJ64-NEXT: c: f8 01 00 90 std 0, 144(1) | ||
; OBJ64-NEXT: 10: 90 61 00 7c stw 3, 124(1) | ||
; OBJ64-NEXT: 14: 48 00 00 31 bl 0x44 <.foo> | ||
; OBJ64-NEXT: 0000000000000014: R_RBR .foo | ||
; OBJ64-NEXT: 18: 60 00 00 00 nop | ||
; OBJ64: 0000000000000044 <.foo>: | ||
; OBJ64-NEXT: 44: 38 60 00 03 li 3, 3 | ||
; OBJ64-NEXT: 48: 4e 80 00 20 blr |