Skip to content

Commit

Permalink
[ELF] Make InputSection smaller
Browse files Browse the repository at this point in the history
On LP64/Windows platforms, this decreases sizeof(InputSection) from 208 (larger
on Windows) to 184.

For a large executable (7.6GiB, inputSections.size()=5105122,
make<InputSection> called 4835760 times), this decreases cgroup
memory.max_usage_in_bytes by 0.6%

Reviewed By: grimar

Differential Revision: https://reviews.llvm.org/D91018
  • Loading branch information
MaskRay committed Nov 9, 2020
1 parent 9c098d3 commit 2eccde4
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions lld/ELF/InputSection.h
Expand Up @@ -52,15 +52,15 @@ class SectionBase {
// this but instead this->Repl.
SectionBase *repl;

unsigned sectionKind : 3;
uint8_t sectionKind : 3;

// The next two bit fields are only used by InputSectionBase, but we
// put them here so the struct packs better.

unsigned bss : 1;
uint8_t bss : 1;

// Set for sections that should not be folded by ICF.
unsigned keepUnique : 1;
uint8_t keepUnique : 1;

// The 1-indexed partition that this section is assigned to by the garbage
// collector, or 0 if this section is dead. Normally there is only one
Expand Down Expand Up @@ -134,6 +134,10 @@ class InputSectionBase : public SectionBase {
// and shrinking a section.
unsigned bytesDropped = 0;

// Whether the section needs to be padded with a NOP filler due to
// deleteFallThruJmpInsn.
bool nopFiller = false;

void drop_back(uint64_t num) { bytesDropped += num; }

void push_back(uint64_t num) {
Expand Down Expand Up @@ -210,17 +214,13 @@ class InputSectionBase : public SectionBase {
// The native ELF reloc data type is not very convenient to handle.
// So we convert ELF reloc records to our own records in Relocations.cpp.
// This vector contains such "cooked" relocations.
std::vector<Relocation> relocations;

// Indicates that this section needs to be padded with a NOP filler if set to
// true.
bool nopFiller = false;
SmallVector<Relocation, 0> relocations;

// These are modifiers to jump instructions that are necessary when basic
// block sections are enabled. Basic block sections creates opportunities to
// relax jump instructions at basic block boundaries after reordering the
// basic blocks.
std::vector<JumpInstrMod> jumpInstrMods;
SmallVector<JumpInstrMod, 0> jumpInstrMods;

// A function compiled with -fsplit-stack calling a function
// compiled without -fsplit-stack needs its prologue adjusted. Find
Expand Down Expand Up @@ -390,6 +390,8 @@ class InputSection : public InputSectionBase {
template <class ELFT> void copyShtGroup(uint8_t *buf);
};

static_assert(sizeof(InputSection) <= 184, "InputSection is too big");

inline bool isDebugSection(const InputSectionBase &sec) {
return sec.name.startswith(".debug") || sec.name.startswith(".zdebug");
}
Expand Down

0 comments on commit 2eccde4

Please sign in to comment.