Skip to content

Commit

Permalink
[libcxx] Remove nonstandard _FilesystemClock::{to,from}_time_t
Browse files Browse the repository at this point in the history
These are not standard methods, neither libstdc++ nor MSVC STL provide
them.

In practice, one of them was untested and the other one was only used in
one single test.

Differential Revision: https://reviews.llvm.org/D113027
  • Loading branch information
mstorsjo committed Nov 4, 2021
1 parent 531d877 commit 341cc1b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 16 deletions.
4 changes: 4 additions & 0 deletions libcxx/docs/ReleaseNotes.rst
Expand Up @@ -78,6 +78,10 @@ API Changes
exceeds the maximum supported size, as required by the C++ standard.
Previously the type ``std::length_error`` was used.

- Removed the nonstandard methods ``std::chrono::file_clock::to_time_t`` and
``std::chrono::file_clock::from_time_t``; neither libstdc++ nor MSVC STL
had such methods.

ABI Changes
-----------

Expand Down
13 changes: 0 additions & 13 deletions libcxx/include/chrono
Expand Up @@ -2798,19 +2798,6 @@ struct _FilesystemClock {
static _LIBCPP_CONSTEXPR_AFTER_CXX11 const bool is_steady = false;

_LIBCPP_AVAILABILITY_FILESYSTEM _LIBCPP_FUNC_VIS static time_point now() noexcept;

_LIBCPP_INLINE_VISIBILITY
static time_t to_time_t(const time_point& __t) noexcept {
typedef chrono::duration<rep> __secs;
return time_t(
chrono::duration_cast<__secs>(__t.time_since_epoch()).count());
}

_LIBCPP_INLINE_VISIBILITY
static time_point from_time_t(time_t __t) noexcept {
typedef chrono::duration<rep> __secs;
return time_point(__secs(__t));
}
};
_LIBCPP_END_NAMESPACE_FILESYSTEM
#endif // !_LIBCPP_CXX03_LANG
Expand Down
Expand Up @@ -433,7 +433,6 @@ TEST_CASE(read_last_write_time_static_env_test)

TEST_CASE(get_last_write_time_dynamic_env_test)
{
using Clock = file_time_type::clock;
using Sec = std::chrono::seconds;
scoped_test_env env;

Expand All @@ -446,11 +445,9 @@ TEST_CASE(get_last_write_time_dynamic_env_test)
const TimeSpec dir_write_time = dir_times.write;

file_time_type ftime = last_write_time(file);
TEST_CHECK(Clock::to_time_t(ftime) == file_write_time.tv_sec);
TEST_CHECK(CompareTime(ftime, file_write_time));

file_time_type dtime = last_write_time(dir);
TEST_CHECK(Clock::to_time_t(dtime) == dir_write_time.tv_sec);
TEST_CHECK(CompareTime(dtime, dir_write_time));

SleepFor(Sec(2));
Expand Down

0 comments on commit 341cc1b

Please sign in to comment.