Skip to content

Commit

Permalink
[Modules][Test][NFC] Fix -Wsign-compare in clang/unittests/Lex/Module…
Browse files Browse the repository at this point in the history
…DeclStateTest.cpp

In file included from /data/jiefu/llvm-project/clang/unittests/Lex/ModuleDeclStateTest.cpp:22:
/data/jiefu/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1526:11: error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]
  if (lhs == rhs) {
      ~~~ ^  ~~~
/data/jiefu/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1553:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
           ^
/data/jiefu/llvm-project/clang/unittests/Lex/ModuleDeclStateTest.cpp:124:3: note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, int, nullptr>' requested here
  EXPECT_EQ(Callback->importNamedModuleNum(), 0);
  ^
/data/jiefu/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2027:54: note: expanded from macro 'EXPECT_EQ'
  EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
                                                     ^
1 error generated.
  • Loading branch information
DamonFool committed Feb 10, 2023
1 parent 591fdcd commit 35537ae
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions clang/unittests/Lex/ModuleDeclStateTest.cpp
Expand Up @@ -121,7 +121,7 @@ export module foo;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -140,7 +140,7 @@ module foo;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_TRUE(PP->isInImplementationUnit());
Expand All @@ -159,7 +159,7 @@ module foo:part;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -178,7 +178,7 @@ export module foo:part;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -197,7 +197,7 @@ export module foo.dot:part.dot;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -216,7 +216,7 @@ TEST_F(ModuleDeclStateTest, NotModule) {

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_FALSE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -242,7 +242,7 @@ import :another;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 2);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)2);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -269,7 +269,7 @@ import :another;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 2);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)2);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -295,7 +295,7 @@ import :another;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 1);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)1);
EXPECT_FALSE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -315,7 +315,7 @@ TEST_F(ModuleDeclStateTest, ImportAClangNamedModule) {

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 1);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)1);
EXPECT_FALSE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand All @@ -339,7 +339,7 @@ import M2;

auto *Callback =
static_cast<CheckNamedModuleImportingCB *>(PP->getPPCallbacks());
EXPECT_EQ(Callback->importNamedModuleNum(), 4);
EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)4);
EXPECT_FALSE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
Expand Down

0 comments on commit 35537ae

Please sign in to comment.