Skip to content

Commit

Permalink
Revert "Revert rC322769: [RISCV] Propagate -mabi and -march values to…
Browse files Browse the repository at this point in the history
… GNU assembler."

Summary: Bringing back the code change and simplified test cases to test 32/64 bit targets.

Reviewers: asb, yroux, inouehrs, mgrang

Reviewed By: yroux, inouehrs

Subscribers: cfe-commits, rbar, johnrusso, simoncook, jordy.potman.lists, sabuasal, niosHD

Differential Revision: https://reviews.llvm.org/D42666

llvm-svn: 323894
  • Loading branch information
Ana Pazos committed Jan 31, 2018
1 parent b9b6ed9 commit 3625e05
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
12 changes: 12 additions & 0 deletions clang/lib/Driver/ToolChains/Gnu.cpp
Expand Up @@ -629,6 +629,18 @@ void tools::gnutools::Assembler::ConstructJob(Compilation &C,
ppc::getPPCAsmModeForCPU(getCPUName(Args, getToolChain().getTriple())));
break;
}
case llvm::Triple::riscv32:
case llvm::Triple::riscv64: {
StringRef ABIName = riscv::getRISCVABI(Args, getToolChain().getTriple());
CmdArgs.push_back("-mabi");
CmdArgs.push_back(ABIName.data());
if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) {
StringRef MArch = A->getValue();
CmdArgs.push_back("-march");
CmdArgs.push_back(MArch.data());
}
break;
}
case llvm::Triple::sparc:
case llvm::Triple::sparcel: {
CmdArgs.push_back("-32");
Expand Down
19 changes: 19 additions & 0 deletions clang/test/Driver/riscv-gnutools.c
@@ -0,0 +1,19 @@
// Check gnutools are invoked with propagated values for -mabi and -march.

// RUN: %clang -target riscv32 -fno-integrated-as %s -### -c \
// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP32 %s

// RUN: %clang -target riscv32 -fno-integrated-as -march=rv32g %s -### -c \
// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP32-MARCH-G %s

// RUN: %clang -target riscv64 -fno-integrated-as %s -### -c \
// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP64 %s

// RUN: %clang -target riscv64 -fno-integrated-as -march=rv64g %s -### -c \
// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP64-MARCH-G %s

// MABI-ILP32: "{{.*}}as{{(.exe)?}}" "-mabi" "ilp32"
// MABI-ILP32-MARCH-G: "{{.*}}as{{(.exe)?}}" "-mabi" "ilp32" "-march" "rv32g"

// MABI-ILP64: "{{.*}}as{{(.exe)?}}" "-mabi" "lp64"
// MABI-ILP64-MARCH-G: "{{.*}}as{{(.exe)?}}" "-mabi" "lp64" "-march" "rv64g"

0 comments on commit 3625e05

Please sign in to comment.