Skip to content

Commit

Permalink
[lit, python] Always add quotes around the python path in lit
Browse files Browse the repository at this point in the history
Summary:
The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by quotes.

This is a companion change to: https://reviews.llvm.org/D50206

Reviewers: asmith, zturner, espindola

Subscribers: emaste, sbc100, arichardson, aheejin, steven_wu, dexonsmith, llvm-commits

Differential Revision: https://reviews.llvm.org/D50282

llvm-svn: 339075
  • Loading branch information
sstamenova committed Aug 6, 2018
1 parent 85be391 commit 38eee64
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lld/test/ELF/lto/cache.ll
Expand Up @@ -13,7 +13,7 @@
; RUN: ls %t.cache | count 4

; Create a file of size 64KB.
; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo

; This should leave the file in place.
; RUN: ld.lld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t3 %t2.o %t.o
Expand Down
2 changes: 1 addition & 1 deletion lld/test/mach-o/dependency_info.yaml
Expand Up @@ -9,7 +9,7 @@
# RUN: -F/Custom/Frameworks \
# RUN: -framework Bar \
# RUN: -framework Foo
# RUN: '%python' %p/Inputs/DependencyDump.py %t.info | FileCheck %s
# RUN: %python %p/Inputs/DependencyDump.py %t.info | FileCheck %s


# CHECK: linker-vers: lld
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/cache.ll
Expand Up @@ -11,7 +11,7 @@
; RUN: ls %t.cache | count 4

; Create a file of size 64KB.
; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo

; This should leave the file in place.
; RUN: wasm-ld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t.wasm %t2.o %t.o
Expand Down

0 comments on commit 38eee64

Please sign in to comment.