Skip to content

Commit

Permalink
[X86] combineX86ShufflesRecursively - remove old FIXME comment. NFC.
Browse files Browse the repository at this point in the history
Its unlikely an undef element in a zero vector will be any use, and SimplifyDemandedVectorElts now calls combineX86ShufflesRecursively so its unlikely we actually have a dependency on these specific elements.
  • Loading branch information
RKSimon committed Dec 2, 2020
1 parent 793192d commit 3900ec6
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions llvm/lib/Target/X86/X86ISelLowering.cpp
Expand Up @@ -36248,10 +36248,6 @@ static SDValue combineX86ShufflesRecursively(
// Handle the all undef/zero cases early.
if (all_of(Mask, [](int Idx) { return Idx == SM_SentinelUndef; }))
return DAG.getUNDEF(Root.getValueType());

// TODO - should we handle the mixed zero/undef case as well? Just returning
// a zero mask will lose information on undef elements possibly reducing
// future combine possibilities.
if (all_of(Mask, [](int Idx) { return Idx < 0; }))
return getZeroVector(Root.getSimpleValueType(), Subtarget, DAG,
SDLoc(Root));
Expand Down

0 comments on commit 3900ec6

Please sign in to comment.