-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
The pass assumed that all fun.func symbol usages could be safely replaced by undef, that is not true after #87796 that added a back link from internal procedure back to the parent procedure. This caused the internal procedures to be erased and then processed (segfault). Also set visibility of such internal procedures so that MLIR do not remove them before the target function is generated for the target region.
- Loading branch information
1 parent
cd3e71f
commit 3abcd5f
Showing
2 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
! RUN: %flang_fc1 -fopenmp -flang-experimental-hlfir -emit-llvm %s -o - | FileCheck --check-prefixes=LLVM-HOST,LLVM-ALL %s | ||
! RUN: %flang_fc1 -fopenmp -emit-hlfir %s -o - | FileCheck --check-prefixes=MLIR-HOST,MLIR-ALL %s | ||
! RUN: %flang_fc1 -fopenmp -fopenmp-is-target-device -flang-experimental-hlfir -emit-llvm %s -o - | FileCheck --check-prefixes=LLVM-DEVICE,LLVM-ALL %s | ||
! RUN: %flang_fc1 -fopenmp -fopenmp-is-target-device -emit-hlfir %s -o - | FileCheck --check-prefixes=MLIR-DEVICE,MLIR-ALL %s | ||
! RUN: bbc -fopenmp -emit-hlfir %s -o - | FileCheck --check-prefixes=MLIR-HOST,MLIR-ALL %s | ||
! RUN: bbc -fopenmp -fopenmp-is-target-device -emit-hlfir %s -o - | FileCheck --check-prefixes=MLIR-DEVICE,MLIR-ALL %s | ||
|
||
! Check that the correct LLVM IR functions are kept for the host and device | ||
! after running the whole set of translation and transformation passes from | ||
! Fortran. | ||
|
||
! MLIR-HOST: func.func @{{.*}}host_parent_procedure( | ||
! MLIR-HOST: return | ||
! MLIR-DEVICE-NOT: func.func {{.*}}host_parent_procedure( | ||
|
||
! LLVM-HOST: define {{.*}} @host_parent_procedure{{.*}}( | ||
! LLVM-DEVICE-NOT: {{.*}} @{{.*}}_host_parent_procedure{{.*}}( | ||
subroutine host_parent_procedure(x) | ||
integer, intent(out) :: x | ||
call target_internal_proc(x) | ||
contains | ||
! MLIR-ALL: func.func {{.*}}@_QFhost_parent_procedurePtarget_internal_proc( | ||
|
||
! LLVM-HOST: define {{.*}} @_QFhost_parent_procedurePtarget_internal_proc( | ||
! LLVM-DEVICE-NOT: define {{.*}} @_QFhost_parent_procedurePtarget_internal_proc( | ||
! LLVM-ALL: define {{.*}} @__omp_offloading_{{.*}}QFhost_parent_procedurePtarget_internal_proc{{.*}}( | ||
|
||
subroutine target_internal_proc(x) | ||
integer, intent(out) :: x | ||
!$omp target map(from:x) | ||
x = 10 | ||
!$omp end target | ||
end subroutine | ||
end subroutine |