Add asserts and comments

llvm · Nov 1, 2023 · 3b279bc · 3b279bc
1 parent 9ebb155
commit 3b279bc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h b/llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h
@@ -1182,17 +1182,29 @@ namespace X86II {
     }
   }
 
+  /// \returns true if the register is a XMM.
   inline bool isXMMReg(unsigned RegNo) {
+    assert(X86::XMM15 - X86::XMM0 == 15 &&
+           "XMM0-15 registers are not continuous");
+    assert(X86::XMM31 - X86::XMM16 == 15 &&
+           "XMM16-31 registers are not continuous");
     return (RegNo >= X86::XMM0 && RegNo <= X86::XMM15) ||
            (RegNo >= X86::XMM16 && RegNo <= X86::XMM31);
   }
 
+  /// \returns true if the register is a YMM.
   inline bool isYMMReg(unsigned RegNo) {
+    assert(X86::YMM15 - X86::YMM0 == 15 &&
+           "YMM0-15 registers are not continuous");
+    assert(X86::YMM31 - X86::YMM16 == 15 &&
+           "YMM16-31 registers are not continuous");
     return (RegNo >= X86::YMM0 && RegNo <= X86::YMM15) ||
            (RegNo >= X86::YMM16 && RegNo <= X86::YMM31);
   }
 
+  /// \returns true if the register is a ZMM.
   inline bool isZMMReg(unsigned RegNo) {
+    assert(X86::ZMM31 - X86::ZMM0 == 31 && "ZMM registers are not continuous");
     return RegNo >= X86::ZMM0 && RegNo <= X86::ZMM31;
   }
 

diff --git a/llvm/lib/Target/X86/X86RegisterInfo.cpp b/llvm/lib/Target/X86/X86RegisterInfo.cpp
@@ -631,6 +631,11 @@ unsigned X86RegisterInfo::getNumSupportedRegs(const MachineFunction &MF) const {
   //
   // and try to return the minimum number of registers supported by the target.
 
+  assert((X86::R15WH + 1 == X86 ::YMM0) && (X86::YMM15 + 1 == X86::K0) &&
+         (X86::K6_K7 + 1 == X86::TMMCFG) &&
+         (X86::TMM7 + 1 == X86::NUM_TARGET_REGS) &&
+         "Register number may be incorrect");
+
   bool HasAVX = ST.hasAVX();
   bool HasAVX512 = ST.hasAVX512();
   bool HasAMX = ST.hasAMXTILE();