-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "For #64088: mark vtable as used if we might emit a reference …
…to it." This reverts commit b6847ed.
- Loading branch information
1 parent
7010a4f
commit 3b34d69
Showing
2 changed files
with
0 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b34d69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should mention why you reverted a commit.
3b34d69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second @tbaederr. Please explain it and file an issue if appropriate! This revert regresses the build of SerenityOS.
3b34d69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(There's some follow-up at https://reviews.llvm.org/rG3b34d69ac7a643742364be3591b324ddd14ef9aa#1234621 . I think at least at the moment, comments on commits are more common over on phab than on github.)
3b34d69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Also some follow-up at #64088)