Skip to content

Commit

Permalink
AMDGPU/GlobalISel: Remove leftover setAction
Browse files Browse the repository at this point in the history
Also move G_GEP actions together.

llvm-svn: 352168
  • Loading branch information
arsenm committed Jan 25, 2019
1 parent 3e08b77 commit 3b9a82f
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST,

setAction({G_BRCOND, S1}, Legal);

setAction({G_ASHR, S32}, Legal);
setAction({G_ASHR, 1, S32}, Legal);

getActionDefinitionsBuilder({G_ADD, G_SUB, G_MUL, G_UMULH, G_SMULH})
.legalFor({S32})
.scalarize(0);
Expand Down Expand Up @@ -186,6 +183,14 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST,
setAction({G_GEP, 1, IdxTy}, Legal);
}

// FIXME: When RegBankSelect inserts copies, it will only create new registers
// with scalar types. This means we can end up with G_LOAD/G_STORE/G_GEP
// instruction with scalar types for their pointer operands. In assert builds,
// the instruction selector will assert if it sees a generic instruction which
// isn't legal, so we need to tell it that scalar types are legal for pointer
// operands
setAction({G_GEP, S64}, Legal);

setAction({G_BLOCK_ADDR, CodePtr}, Legal);

getActionDefinitionsBuilder({G_ICMP, G_FCMP})
Expand Down Expand Up @@ -288,14 +293,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST,
Shifts.clampScalar(0, S32, S64);
Shifts.clampScalar(1, S32, S32);

// FIXME: When RegBankSelect inserts copies, it will only create new
// registers with scalar types. This means we can end up with
// G_LOAD/G_STORE/G_GEP instruction with scalar types for their pointer
// operands. In assert builds, the instruction selector will assert
// if it sees a generic instruction which isn't legal, so we need to
// tell it that scalar types are legal for pointer operands
setAction({G_GEP, S64}, Legal);

for (unsigned Op : {G_EXTRACT_VECTOR_ELT, G_INSERT_VECTOR_ELT}) {
unsigned VecTypeIdx = Op == G_EXTRACT_VECTOR_ELT ? 1 : 0;
unsigned EltTypeIdx = Op == G_EXTRACT_VECTOR_ELT ? 0 : 1;
Expand Down

0 comments on commit 3b9a82f

Please sign in to comment.