Skip to content

Commit

Permalink
Replace getAs with castAs, dyn_cast with cast (NFC) (#72600)
Browse files Browse the repository at this point in the history
Make the code clear that nullptrs are not expected.
  • Loading branch information
mikerice1969 committed Nov 17, 2023
1 parent 6e31709 commit 3ce5c04
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions clang/lib/AST/ASTContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4014,8 +4014,8 @@ QualType ASTContext::getVectorType(QualType vecType, unsigned NumElts,
assert(vecType->isBuiltinType() ||
(vecType->isBitIntType() &&
// Only support _BitInt elements with byte-sized power of 2 NumBits.
llvm::isPowerOf2_32(vecType->getAs<BitIntType>()->getNumBits()) &&
vecType->getAs<BitIntType>()->getNumBits() >= 8));
llvm::isPowerOf2_32(vecType->castAs<BitIntType>()->getNumBits()) &&
vecType->castAs<BitIntType>()->getNumBits() >= 8));

// Check if we've already instantiated a vector of this type.
llvm::FoldingSetNodeID ID;
Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4402,7 +4402,7 @@ static void updateNVPTXMetadata(Function &Kernel, StringRef Name, int32_t Value,
// Update the "maxntidx" metadata for NVIDIA, or add it.
MDNode *ExistingOp = getNVPTXMDNode(Kernel, Name);
if (ExistingOp) {
auto *OldVal = dyn_cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
auto *OldVal = cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
int32_t OldLimit = cast<ConstantInt>(OldVal->getValue())->getZExtValue();
ExistingOp->replaceOperandWith(
2, ConstantAsMetadata::get(ConstantInt::get(
Expand Down Expand Up @@ -4441,7 +4441,7 @@ OpenMPIRBuilder::readThreadBoundsForKernel(const Triple &T, Function &Kernel) {
}

if (MDNode *ExistingOp = getNVPTXMDNode(Kernel, "maxntidx")) {
auto *OldVal = dyn_cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
auto *OldVal = cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
int32_t UB = cast<ConstantInt>(OldVal->getValue())->getZExtValue();
return {0, ThreadLimit ? std::min(ThreadLimit, UB) : UB};
}
Expand Down

0 comments on commit 3ce5c04

Please sign in to comment.