-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade a rdar://5907648 link to a github issue
- Loading branch information
Showing
2 changed files
with
25 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py | ||
; RUN: llc < %s -mtriple=i386-apple-macosx -mattr=+sse2 | FileCheck %s --check-prefix=X86 | ||
; RUN: llc < %s -mtriple=x86_64-apple-macosx -mattr=+sse2 | FileCheck %s --check-prefix=X64 | ||
|
||
; We get this right for x86-64, but on x86-32 the code is less optimal. | ||
; See: https://github.com/llvm/llvm-project/issues/64174 | ||
define noundef float @i8_to_fp(i8 noundef zeroext %0) { | ||
; X86-LABEL: i8_to_fp: | ||
; X86: ## %bb.0: | ||
; X86-NEXT: pushl %eax | ||
; X86-NEXT: .cfi_def_cfa_offset 8 | ||
; X86-NEXT: movzbl {{[0-9]+}}(%esp), %eax | ||
; X86-NEXT: cvtsi2ss %eax, %xmm0 | ||
; X86-NEXT: movss %xmm0, (%esp) | ||
; X86-NEXT: flds (%esp) | ||
; X86-NEXT: popl %eax | ||
; X86-NEXT: retl | ||
; | ||
; X64-LABEL: i8_to_fp: | ||
; X64: ## %bb.0: | ||
; X64-NEXT: cvtsi2ss %edi, %xmm0 | ||
; X64-NEXT: retq | ||
%2 = uitofp i8 %0 to float | ||
ret float %2 | ||
} |