Skip to content

Commit

Permalink
AMDGPU: Use default attributes on image dim intrinsics
Browse files Browse the repository at this point in the history
These were missing nocallback and willreturn
  • Loading branch information
arsenm committed Dec 30, 2022
1 parent 9f40d9f commit 3eecc83
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions llvm/include/llvm/IR/IntrinsicsAMDGPU.td
Expand Up @@ -793,7 +793,7 @@ class AMDGPUImageDimIntrinsicEval<AMDGPUDimProfile P_> {
// All dimension-aware intrinsics are derived from this class.
class AMDGPUImageDimIntrinsic<AMDGPUDimProfile P_,
list<IntrinsicProperty> props,
list<SDNodeProperty> sdnodeprops> : Intrinsic<
list<SDNodeProperty> sdnodeprops> : DefaultAttrsIntrinsic<
P_.RetTypes, // vdata(VGPR) -- for load/atomic-with-return
!listconcat(
!foreach(arg, P_.DataArgs, arg.Type), // vdata(VGPR) -- for store/atomic
Expand All @@ -808,7 +808,6 @@ class AMDGPUImageDimIntrinsic<AMDGPUDimProfile P_,
!listconcat(props,
!if(P_.IsAtomic, [], [ImmArg<ArgIndex<AMDGPUImageDimIntrinsicEval<P_>.DmaskArgIndex>>]),
!if(P_.IsSample, [ImmArg<ArgIndex<AMDGPUImageDimIntrinsicEval<P_>.UnormArgIndex>>], []),
[IntrWillReturn],
[ImmArg<ArgIndex<AMDGPUImageDimIntrinsicEval<P_>.TexFailCtrlArgIndex>>,
ImmArg<ArgIndex<AMDGPUImageDimIntrinsicEval<P_>.CachePolicyArgIndex>>]),

Expand Down

0 comments on commit 3eecc83

Please sign in to comment.