Skip to content

Commit

Permalink
[mlir][aarch64] Disable bf16 tests on AArch64
Browse files Browse the repository at this point in the history
This patch disables 2 bf16 tests that are currently not supported on
AArch64. I've triaged these failures and opened [1] to track this. I
don't have a simple reproducer for dense_output_bf16.mlir, but it's
rather clear that both tests fail due to missing support for `bfloat`
operations in the AArch64 backend.

I'm not sure what the path forward to enable these tests on AArch64
should be. I think that there are two options:
  * AArch64 backened gains capability to legalize these nodes containing
    `bfloat` operands, or
  * MLIR (similarly to Clang) is taught not to emit such nodes in the
    first place.

[1] #58465

Differential Revision: https://reviews.llvm.org/D136273
  • Loading branch information
banach-space committed Oct 20, 2022
1 parent 9ec0ad7 commit 3f59734
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// RUN: -shared-libs=%mlir_lib_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s

// UNSUPPORTED: aarch64

#SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}>
#DenseVector = #sparse_tensor.encoding<{dimLevelType = ["dense"]}>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// RUN: -shared-libs=%mlir_lib_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s

// UNSUPPORTED: aarch64

!Filename = !llvm.ptr<i8>

#SparseMatrix = #sparse_tensor.encoding<{
Expand Down

0 comments on commit 3f59734

Please sign in to comment.