-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[OBJC] Allow __attribute__((NSObject)) types be used as lightweight g…
…eneric specifiers (#84593) As per https://clang.llvm.org/docs/AutomaticReferenceCounting.html#retainable-object-pointers, types with `__attribute__((NSObject))` are retainable, and thus should be eligible to be used as lightweight generic specifiers. Fix for #84592 84592
- Loading branch information
Showing
2 changed files
with
28 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// RUN: %clang_cc1 -verify -Wno-objc-root-class -fsyntax-only %s | ||
|
||
@interface NSArray<__covariant ObjectType> | ||
- (void)containsObject:(ObjectType)anObject; // expected-note {{passing argument to parameter 'anObject' here}} | ||
- (void)description; | ||
@end | ||
|
||
typedef __attribute__((NSObject)) struct Foo *FooRef; | ||
typedef struct Bar *BarRef; | ||
|
||
void good() { | ||
FooRef object; | ||
NSArray<FooRef> *array; | ||
[array containsObject:object]; | ||
[object description]; | ||
} | ||
|
||
void bad() { | ||
BarRef object; | ||
NSArray<BarRef> *array; // expected-error {{type argument 'BarRef' (aka 'struct Bar *') is neither an Objective-C object nor a block type}} | ||
[array containsObject:object]; // expected-warning {{incompatible pointer types sending 'BarRef' (aka 'struct Bar *') to parameter of type 'id'}} | ||
[object description]; // expected-warning {{receiver type 'BarRef' (aka 'struct Bar *') is not 'id' or interface pointer, consider casting it to 'id'}} | ||
} |