Skip to content

Commit

Permalink
[lldb/crashlog] Fix the image_regex_uuid to skip null UUID images
Browse files Browse the repository at this point in the history
This patch updates the image_regex_uuid matcher to match null-UUID
images in the plain text crashlog parser.

It updates the regex to match one or more '?' characters or the image
full path.

rdar://100904019

Differential Revision: https://reviews.llvm.org/D135482

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
  • Loading branch information
medismailben committed Nov 3, 2022
1 parent 3be8643 commit 42df155
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lldb/examples/python/crashlog.py
Expand Up @@ -623,7 +623,7 @@ class TextCrashLogParser(CrashLogParser):
r'[+]?(.+?)\s+' # img_name
r'(?:(' +version+ r')\s+)?' # img_version
r'(?:<([-0-9a-fA-F]+)>\s+)?' # img_uuid
r'(/.*)' # img_path
r'(\?+|/.*)' # img_path
)
exception_type_regex = re.compile(r'^Exception Type:\s+(EXC_[A-Z_]+)(?:\s+\((.*)\))?')
exception_codes_regex = re.compile(r'^Exception Codes:\s+(0x[0-9a-fA-F]+),\s*(0x[0-9a-fA-F]+)')
Expand Down
Expand Up @@ -47,3 +47,4 @@ Trap Number: 14

Binary Images:
0x100000000 - 0x200000000 +a.out (0) <@UUID@> @EXEC@
0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???

0 comments on commit 42df155

Please sign in to comment.