Skip to content

Commit

Permalink
[lldb] Add MacroQualified switch cases for r360109
Browse files Browse the repository at this point in the history
Summary:
r360109 added a new enum case, causing lldb build to fail with several errors like:
lldb/source/Symbol/ClangASTContext.cpp:4342:11: error: enumeration value 'MacroQualified' not handled in switch [-Werror,-Wswitch]
  switch (qual_type->getTypeClass()) {
          ^
This adds the missing switch cases.
I'm not an lldb maintainer and just used my best judgement that it's probably expected that we break in these cases. Feel free to ping / revert / fix this change if this behavior is not appropriate.

Reviewers: gribozavr

Reviewed By: gribozavr

Differential Revision: https://reviews.llvm.org/D61640

llvm-svn: 360146
  • Loading branch information
krasimirgg committed May 7, 2019
1 parent 54743d5 commit 435e76a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lldb/source/Symbol/ClangASTContext.cpp
Expand Up @@ -4469,6 +4469,8 @@ ClangASTContext::GetTypeClass(lldb::opaque_compiler_type_t type) {

case clang::Type::DependentAddressSpace:
break;
case clang::Type::MacroQualified:
break;
}
// We don't know hot to display this type...
return lldb::eTypeClassOther;
Expand Down Expand Up @@ -5337,6 +5339,8 @@ lldb::Encoding ClangASTContext::GetEncoding(lldb::opaque_compiler_type_t type,

case clang::Type::DependentAddressSpace:
break;
case clang::Type::MacroQualified:
break;
}
count = 0;
return lldb::eEncodingInvalid;
Expand Down Expand Up @@ -5504,6 +5508,8 @@ lldb::Format ClangASTContext::GetFormat(lldb::opaque_compiler_type_t type) {

case clang::Type::DependentAddressSpace:
break;
case clang::Type::MacroQualified:
break;
}
// We don't know hot to display this type...
return lldb::eFormatBytes;
Expand Down

0 comments on commit 435e76a

Please sign in to comment.