Skip to content

Commit

Permalink
Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE
Browse files Browse the repository at this point in the history
and fix resulting errors. This is a prerequisite for building each
test variant in its own build directory.

llvm-svn: 323789
  • Loading branch information
adrian-prantl committed Jan 30, 2018
1 parent d6d5a25 commit 43a68f1
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
class SBDirCheckerCase(TestBase):

mydir = TestBase.compute_mydir(__file__)
NO_DEBUG_INFO_TESTCASE = True

def setUp(self):
TestBase.setUp(self)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

class SBBreakpointCallbackCase(TestBase):

NO_DEBUG_INFO_TESTCASE = True

def setUp(self):
TestBase.setUp(self)
self.generateSource('driver.cpp')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@
class TestArray(TestBase):
mydir = TestBase.compute_mydir(__file__)

def setUp(self):
TestBase.setUp(self)

@skipUnlessDarwin
@skipIfDarwinEmbedded # <rdar://problem/33842388> frame diagnose doesn't work for armv7 or arm64
def test_array(self):
TestBase.setUp(self)
self.build()
exe = self.getBuildArtifact("a.out")
self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
Expand Down
2 changes: 2 additions & 0 deletions lldb/packages/Python/lldbsuite/test/lldbtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1497,6 +1497,8 @@ def buildDefault(
dictionary=None,
clean=True):
"""Platform specific way to build the default binaries."""
if self.debug_info:
raise Exception("buildDefault tests must set NO_DEBUG_INFO_TESTCASE")
module = builder_module()
dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
if not module.buildDefault(
Expand Down

0 comments on commit 43a68f1

Please sign in to comment.