Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
As specified in the MLIR language reference and rationale documents, `memref` types should not be allowed to have `index` as element types. As observed in https://groups.google.com/a/tensorflow.org/forum/#!msg/mlir/P49hVWqTMNc/nW89a4i_AgAJ this restriction was lifted when canonicalization unit tests for affine operations were introduced, without sufficient motivation to lift the restriction itself. The test in question can be trivially rewritten (return the value from a function instead of storing it to prevent DCE from removing the producer operation) and the restriction put back in place. If `memref<...x index>` is relevant for some use cases, the relaxation of the type system can be implemented separately with appropriate modifications to the documentation. PiperOrigin-RevId: 272607043
- Loading branch information
1 parent
9604bb6
commit 44ef5e5
Showing
3 changed files
with
10 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters