Skip to content

Commit

Permalink
ELF2: Rename undefError -> reportUndefined.
Browse files Browse the repository at this point in the history
The new name starts with a verb, and it does not imply that it errors
out and exit (it acutally can just emit a warning depending on settings.)

llvm-svn: 249016
  • Loading branch information
rui314 committed Oct 1, 2015
1 parent cf1670a commit 44f5d91
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lld/ELF/Writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ void Writer<ELFT>::scanRelocs(const InputSection<ELFT> &C) {
}

template <class ELFT>
static void undefError(const SymbolTable &S, const SymbolBody &Sym) {
static void reportUndefined(const SymbolTable &S, const SymbolBody &Sym) {
typedef typename ELFFile<ELFT>::Elf_Sym Elf_Sym;
typedef typename ELFFile<ELFT>::Elf_Sym_Range Elf_Sym_Range;

Expand Down Expand Up @@ -337,7 +337,7 @@ template <class ELFT> void Writer<ELFT>::createSections() {
StringRef Name = P.first;
SymbolBody *Body = P.second->Body;
if (Body->isStrongUndefined())
undefError<ELFT>(Symtab, *Body);
reportUndefined<ELFT>(Symtab, *Body);

if (auto *C = dyn_cast<DefinedCommon<ELFT>>(Body))
CommonSymbols.push_back(C);
Expand Down

0 comments on commit 44f5d91

Please sign in to comment.