Skip to content

Commit

Permalink
workflows: Use uncompressed abi dumps
Browse files Browse the repository at this point in the history
The compressed dumps are no longer readable, but I'm not sure why.
  • Loading branch information
tstellar committed May 7, 2021
1 parent 372e6fb commit 452500e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/libclang-abi-tests.yml
Expand Up @@ -113,13 +113,12 @@ jobs:
for lib in ${{ needs.abi-dump-setup.outputs.ABI_LIBS }}; do
# Remove symbol versioning from dumps, so we can compare across major versions.
sed -i 's/LLVM_${{ matrix.llvm_version_major }}/LLVM_NOVERSION/' $lib-${{ matrix.ref }}.abi
tar -czf $lib-${{ matrix.ref }}.abi.tar.gz $lib-${{ matrix.ref }}.abi
done
- name: Upload ABI file
uses: actions/upload-artifact@v2
with:
name: ${{ matrix.name }}
path: "*${{ matrix.ref }}.abi.tar.gz"
path: "*${{ matrix.ref }}.abi"

abi-compare:
runs-on: ubuntu-latest
Expand All @@ -141,7 +140,7 @@ jobs:
- name: Compare ABI
run: |
for lib in ${{ needs.abi-dump-setup.outputs.ABI_LIBS }}; do
abi-compliance-checker -lib $lib -old build-baseline/$lib*.abi.tar.gz -new build-latest/$lib*.abi.tar.gz
abi-compliance-checker -lib $lib -old build-baseline/$lib*.abi -new build-latest/$lib*.abi
done
- name: Upload ABI Comparison
if: always()
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/llvm-tests.yml
Expand Up @@ -126,12 +126,11 @@ jobs:
abi-dumper $EXTRA_ARGS -lver ${{ matrix.ref }} -skip-cxx -public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS }} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
# Remove symbol versioning from dumps, so we can compare across major versions.
sed -i 's/LLVM_${{ matrix.llvm_version_major }}/LLVM_NOVERSION/' ${{ matrix.ref }}.abi
tar -czf ${{ matrix.ref }}.abi.tar.gz ${{ matrix.ref }}.abi
- name: Upload ABI file
uses: actions/upload-artifact@v1
with:
name: ${{ matrix.name }}
path: ${{ matrix.ref }}.abi.tar.gz
path: ${{ matrix.ref }}.abi

- name: Upload symbol list file
if: matrix.name == 'build-baseline'
Expand Down Expand Up @@ -167,7 +166,10 @@ jobs:
# This option doesn't seem to work with the ABI dumper, so passing it here.
export EXTRA_ARGS="-symbols-list symbol-list/llvm.symbols"
fi
abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old build-baseline/*.tar.gz -new build-latest/*.tar.gz || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
# FIXME: Reading of gzip'd abi files on the GitHub runners stop
# working some time in March of 2021, likely due to a change in the
# runner's environment.
abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
- name: Upload ABI Comparison
if: always()
uses: actions/upload-artifact@v1
Expand Down

0 comments on commit 452500e

Please sign in to comment.