Skip to content

Commit

Permalink
[llvm][NFC] Removed addressed fixme; formatting.
Browse files Browse the repository at this point in the history
Removed already-addressed fixme, and updated formatting of a few lines
that were triggering Harbormaster.
  • Loading branch information
mtrofin committed Apr 29, 2020
1 parent 5e37cf0 commit 4632b72
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions llvm/lib/Transforms/IPO/Inliner.cpp
Expand Up @@ -34,8 +34,6 @@
#include "llvm/Analysis/ProfileSummaryInfo.h"
#include "llvm/Analysis/TargetLibraryInfo.h"
#include "llvm/Analysis/TargetTransformInfo.h"
#include "llvm/Transforms/Utils/Local.h"
#include "llvm/Transforms/Utils/CallPromotionUtils.h"
#include "llvm/IR/Attributes.h"
#include "llvm/IR/BasicBlock.h"
#include "llvm/IR/DataLayout.h"
Expand All @@ -57,8 +55,10 @@
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/Transforms/Utils/CallPromotionUtils.h"
#include "llvm/Transforms/Utils/Cloning.h"
#include "llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h"
#include "llvm/Transforms/Utils/Local.h"
#include "llvm/Transforms/Utils/ModuleUtils.h"
#include <algorithm>
#include <cassert>
Expand Down Expand Up @@ -158,9 +158,9 @@ using InlinedArrayAllocasTy = DenseMap<ArrayType *, std::vector<AllocaInst *>>;
/// *actually make it to the backend*, which is really what we want.
///
/// Because we don't have this information, we do this simple and useful hack.
static void mergeInlinedArrayAllocas(
Function *Caller, InlineFunctionInfo &IFI,
InlinedArrayAllocasTy &InlinedArrayAllocas, int InlineHistory) {
static void mergeInlinedArrayAllocas(Function *Caller, InlineFunctionInfo &IFI,
InlinedArrayAllocasTy &InlinedArrayAllocas,
int InlineHistory) {
SmallPtrSet<AllocaInst *, 16> UsedAllocas;

// When processing our SCC, check to see if CS was inlined from some other
Expand Down Expand Up @@ -1003,8 +1003,7 @@ PreservedAnalyses InlinerPass::run(LazyCallGraph::SCC &InitialC,
// node however because those functions aren't going to be mutated by this
// pass.
FunctionAnalysisManager &FAM =
AM.getResult<FunctionAnalysisManagerCGSCCProxy>(*C, CG)
.getManager();
AM.getResult<FunctionAnalysisManagerCGSCCProxy>(*C, CG).getManager();

// Get the remarks emission analysis for the caller.
auto &ORE = FAM.getResult<OptimizationRemarkEmitterAnalysis>(F);
Expand Down Expand Up @@ -1111,7 +1110,6 @@ PreservedAnalyses InlinerPass::run(LazyCallGraph::SCC &InitialC,
int NewHistoryID = InlineHistory.size();
InlineHistory.push_back({&Callee, InlineHistoryID});

// FIXME(mtrofin): refactor IFI.InlinedCallSites to be CallBase-based
for (CallBase *CS : reverse(IFI.InlinedCallSites)) {
Function *NewCallee = CS->getCalledFunction();
if (!NewCallee) {
Expand Down Expand Up @@ -1237,8 +1235,7 @@ PreservedAnalyses InlinerPass::run(LazyCallGraph::SCC &InitialC,
// function there. Also, cclear out any cached analyses.
auto &DeadC = *CG.lookupSCC(*CG.lookup(*DeadF));
FunctionAnalysisManager &FAM =
AM.getResult<FunctionAnalysisManagerCGSCCProxy>(DeadC, CG)
.getManager();
AM.getResult<FunctionAnalysisManagerCGSCCProxy>(DeadC, CG).getManager();
FAM.clear(*DeadF, DeadF->getName());
AM.clear(DeadC, DeadC.getName());
auto &DeadRC = DeadC.getOuterRefSCC();
Expand Down

0 comments on commit 4632b72

Please sign in to comment.