Skip to content

Commit

Permalink
[VE] Convert test to opaque pointers (NFC)
Browse files Browse the repository at this point in the history
There is a minor codegen regression here (an extra and instruction).
The reason is that CGP only eliminates fallthrough branches if it
has made some other kind of change, and with opaque pointers that
other change does not occur.

Ideally, we should probably always try to eliminate fallthroughs,
but this runs into the problem that performing a dummy fallthrough
is a common pattern in tests for forcing SDAG to select them
separately, so it's not quite that simple.
  • Loading branch information
nikic committed Dec 23, 2022
1 parent 5ce4e92 commit 4861a58
Showing 1 changed file with 527 additions and 559 deletions.

0 comments on commit 4861a58

Please sign in to comment.