Skip to content

Commit

Permalink
[hip] Remove -Werror=format-nonliteral
Browse files Browse the repository at this point in the history
Summary:
- It won't distinguish host and device code and trigger compilation
  failure on irrelevant code.

Reviewers: sameerds, yaxunl

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D73224
  • Loading branch information
darkbuck committed Jan 23, 2020
1 parent 398175e commit 49f7bc9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion clang/lib/Driver/ToolChains/HIP.cpp
Expand Up @@ -425,7 +425,6 @@ Tool *HIPToolChain::buildLinker() const {

void HIPToolChain::addClangWarningOptions(ArgStringList &CC1Args) const {
HostTC.addClangWarningOptions(CC1Args);
CC1Args.push_back("-Werror=format-nonliteral");
}

ToolChain::CXXStdlibType
Expand Down
2 changes: 1 addition & 1 deletion clang/test/Driver/hip-printf.hip
Expand Up @@ -6,4 +6,4 @@
// RUN: %s 2>&1 | FileCheck %s

// CHECK: [[CLANG:".*clang.*"]] "-cc1"
// CHECK-SAME: "-Werror=format-nonliteral"
// CHECK-NOT: "-Werror=format-nonliteral"

0 comments on commit 49f7bc9

Please sign in to comment.