Skip to content

Commit

Permalink
[LLDB][NFC] treat Lua error codes in a more explicit manner
Browse files Browse the repository at this point in the history
This patch is a minor suggestion to not rely on the fact
that the `LUA_OK` macro is 0.

This assumption could change in future versions of the C API.

Differential Revision: https://reviews.llvm.org/D90556
  • Loading branch information
tammela committed Nov 3, 2020
1 parent ca1bcdf commit 4b9fa3b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp
Expand Up @@ -18,7 +18,7 @@ llvm::Error Lua::Run(llvm::StringRef buffer) {
int error =
luaL_loadbuffer(m_lua_state, buffer.data(), buffer.size(), "buffer") ||
lua_pcall(m_lua_state, 0, 0, 0);
if (!error)
if (error == LUA_OK)
return llvm::Error::success();

llvm::Error e = llvm::make_error<llvm::StringError>(
Expand All @@ -44,7 +44,7 @@ llvm::Error Lua::LoadModule(llvm::StringRef filename) {

int error = luaL_loadfile(m_lua_state, filename.data()) ||
lua_pcall(m_lua_state, 0, 1, 0);
if (error) {
if (error != LUA_OK) {
llvm::Error e = llvm::make_error<llvm::StringError>(
llvm::formatv("{0}\n", lua_tostring(m_lua_state, -1)),
llvm::inconvertibleErrorCode());
Expand Down

0 comments on commit 4b9fa3b

Please sign in to comment.