Skip to content

Commit

Permalink
[MSP430] Remove unused MVT::Glue output from MSP430ISD::SELECT_CC nodes.
Browse files Browse the repository at this point in the history
Follow up from a similar patch on RISCV 637f19c

Nothing reads this Glue value that I could see. The SDNode def in
the td file does not have the SDNPOutGlue flag so I don't think
this glue would get properly propagated to MachineSDNodes if it
was used.
  • Loading branch information
topperc committed Nov 12, 2020
1 parent 8df28f0 commit 4cdf1d2
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
Expand Up @@ -1208,9 +1208,8 @@ SDValue MSP430TargetLowering::LowerSETCC(SDValue Op, SelectionDAG &DAG) const {
return SR;
} else {
SDValue Zero = DAG.getConstant(0, dl, VT);
SDVTList VTs = DAG.getVTList(Op.getValueType(), MVT::Glue);
SDValue Ops[] = {One, Zero, TargetCC, Flag};
return DAG.getNode(MSP430ISD::SELECT_CC, dl, VTs, Ops);
return DAG.getNode(MSP430ISD::SELECT_CC, dl, Op.getValueType(), Ops);
}
}

Expand All @@ -1226,10 +1225,9 @@ SDValue MSP430TargetLowering::LowerSELECT_CC(SDValue Op,
SDValue TargetCC;
SDValue Flag = EmitCMP(LHS, RHS, TargetCC, CC, dl, DAG);

SDVTList VTs = DAG.getVTList(Op.getValueType(), MVT::Glue);
SDValue Ops[] = {TrueV, FalseV, TargetCC, Flag};

return DAG.getNode(MSP430ISD::SELECT_CC, dl, VTs, Ops);
return DAG.getNode(MSP430ISD::SELECT_CC, dl, Op.getValueType(), Ops);
}

SDValue MSP430TargetLowering::LowerSIGN_EXTEND(SDValue Op,
Expand Down

0 comments on commit 4cdf1d2

Please sign in to comment.