Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FuncSpec] Don't specialise call sites that have the MinSize attribut…
…e set The MinSize attribute can be attached to both the callee and the caller in the callsite. Function specialisation was already skipped for function declarations (callees) with MinSize. This also skips specialisations for the callsite when it has MinSize set. Differential Revision: https://reviews.llvm.org/D109441
- Loading branch information
Sjoerd Meijer
committed
Sep 10, 2021
1 parent
24332f0
commit 4f9217c
Showing
3 changed files
with
101 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
llvm/test/Transforms/FunctionSpecialization/function-specialization-minsize2.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
; RUN: opt -function-specialization -func-specialization-size-threshold=3 -S < %s | FileCheck %s | ||
|
||
; Checks for callsites that have been annotated with MinSize. No specialisation | ||
; expected here: | ||
; | ||
; CHECK-NOT: @compute.1 | ||
; CHECK-NOT: @compute.2 | ||
|
||
define i64 @main(i64 %x, i1 %flag) { | ||
entry: | ||
br i1 %flag, label %plus, label %minus | ||
|
||
plus: | ||
%tmp0 = call i64 @compute(i64 %x, i64 (i64)* @plus) #0 | ||
br label %merge | ||
|
||
minus: | ||
%tmp1 = call i64 @compute(i64 %x, i64 (i64)* @minus) #0 | ||
br label %merge | ||
|
||
merge: | ||
%tmp2 = phi i64 [ %tmp0, %plus ], [ %tmp1, %minus] | ||
ret i64 %tmp2 | ||
} | ||
|
||
define internal i64 @compute(i64 %x, i64 (i64)* %binop) { | ||
entry: | ||
%tmp0 = call i64 %binop(i64 %x) | ||
ret i64 %tmp0 | ||
} | ||
|
||
define internal i64 @plus(i64 %x) { | ||
entry: | ||
%tmp0 = add i64 %x, 1 | ||
ret i64 %tmp0 | ||
} | ||
|
||
define internal i64 @minus(i64 %x) { | ||
entry: | ||
%tmp0 = sub i64 %x, 1 | ||
ret i64 %tmp0 | ||
} | ||
|
||
attributes #0 = { minsize optsize } |
48 changes: 48 additions & 0 deletions
48
llvm/test/Transforms/FunctionSpecialization/function-specialization-minsize3.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
; RUN: opt -function-specialization -func-specialization-size-threshold=3 -S < %s | FileCheck %s | ||
|
||
; Checks for callsites that have been annotated with MinSize. We only expect | ||
; specialisation for the call that does not have the attribute: | ||
; | ||
; CHECK: plus: | ||
; CHECK: %tmp0 = call i64 @compute.1(i64 %x, i64 (i64)* @plus) | ||
; CHECK: br label %merge | ||
; CHECK: minus: | ||
; CHECK: %tmp1 = call i64 @compute(i64 %x, i64 (i64)* @minus) #0 | ||
; CHECK: br label %merge | ||
; | ||
define i64 @main(i64 %x, i1 %flag) { | ||
entry: | ||
br i1 %flag, label %plus, label %minus | ||
|
||
plus: | ||
%tmp0 = call i64 @compute(i64 %x, i64 (i64)* @plus) | ||
br label %merge | ||
|
||
minus: | ||
%tmp1 = call i64 @compute(i64 %x, i64 (i64)* @minus) #0 | ||
br label %merge | ||
|
||
merge: | ||
%tmp2 = phi i64 [ %tmp0, %plus ], [ %tmp1, %minus] | ||
ret i64 %tmp2 | ||
} | ||
|
||
define internal i64 @compute(i64 %x, i64 (i64)* %binop) { | ||
entry: | ||
%tmp0 = call i64 %binop(i64 %x) | ||
ret i64 %tmp0 | ||
} | ||
|
||
define internal i64 @plus(i64 %x) { | ||
entry: | ||
%tmp0 = add i64 %x, 1 | ||
ret i64 %tmp0 | ||
} | ||
|
||
define internal i64 @minus(i64 %x) { | ||
entry: | ||
%tmp0 = sub i64 %x, 1 | ||
ret i64 %tmp0 | ||
} | ||
|
||
attributes #0 = { minsize optsize } |