[Verifier] Pass raw_ostream as pointer instead of reference

This can be nullptr and ubsan found a couple of cases in LLVM's unit tests.
llvm · Aug 1, 2023 · 502280e · 502280e
1 parent 9d927d0
commit 502280e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/llvm/include/llvm/ADT/GenericConvergenceVerifier.h b/llvm/include/llvm/ADT/GenericConvergenceVerifier.h
@@ -30,11 +30,11 @@ template <typename ContextT> class GenericConvergenceVerifier {
   using CycleInfoT = GenericCycleInfo<ContextT>;
   using CycleT = typename CycleInfoT::CycleT;
 
-  void initialize(raw_ostream &OS,
+  void initialize(raw_ostream *OS,
                   function_ref<void(const Twine &Message)> FailureCB,
                   const FunctionT &F) {
     clear();
-    this->OS = &OS;
+    this->OS = OS;
     this->FailureCB = FailureCB;
     Context = ContextT(&F);
   }

diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
@@ -408,7 +408,7 @@ class Verifier : public InstVisitor<Verifier>, VerifierSupport {
     auto FailureCB = [this](const Twine &Message) {
       this->CheckFailed(Message);
     };
-    CV.initialize(*OS, FailureCB, F);
+    CV.initialize(OS, FailureCB, F);
 
     Broken = false;
     // FIXME: We strip const here because the inst visitor strips const.