Skip to content

Commit

Permalink
[NFC] Fixed enum constant in boolean context error
Browse files Browse the repository at this point in the history
Summary:
/home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:656:59: warning: enum constant in boolean context [-Wint-in-bool-context]
     if (mh.magic == llvm::MachO::MH_CIGAM || llvm::MachO::MH_MAGIC)
                                                           ^~~~~~~~
/home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:658:62: warning: enum constant in boolean context [-Wint-in-bool-context]
     if (mh.magic == llvm::MachO::MH_CIGAM_64 || llvm::MachO::MH_MAGIC_64)

Reviewers: JDevlieghere, teemperor

Reviewed By: teemperor

Subscribers: abidh, lldb-commits

Differential Revision: https://reviews.llvm.org/D51600

llvm-svn: 341340
  • Loading branch information
davidbolvansky committed Sep 3, 2018
1 parent 122441d commit 52cadf0
Showing 1 changed file with 6 additions and 5 deletions.
Expand Up @@ -652,11 +652,12 @@ bool DynamicLoaderDarwinKernel::KextImageInfo::ReadMemoryModule(

llvm::MachO::mach_header mh;
size_t size_to_read = 512;
if (ReadMachHeader (m_load_address, process, mh)) {
if (mh.magic == llvm::MachO::MH_CIGAM || llvm::MachO::MH_MAGIC)
size_to_read = sizeof (llvm::MachO::mach_header) + mh.sizeofcmds;
if (mh.magic == llvm::MachO::MH_CIGAM_64 || llvm::MachO::MH_MAGIC_64)
size_to_read = sizeof (llvm::MachO::mach_header_64) + mh.sizeofcmds;
if (ReadMachHeader(m_load_address, process, mh)) {
if (mh.magic == llvm::MachO::MH_CIGAM || mh.magic == llvm::MachO::MH_MAGIC)
size_to_read = sizeof(llvm::MachO::mach_header) + mh.sizeofcmds;
if (mh.magic == llvm::MachO::MH_CIGAM_64 ||
mh.magic == llvm::MachO::MH_MAGIC_64)
size_to_read = sizeof(llvm::MachO::mach_header_64) + mh.sizeofcmds;
}

ModuleSP memory_module_sp =
Expand Down

0 comments on commit 52cadf0

Please sign in to comment.