Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The inlining semantics for C and C++ are different, which affects the test's expectation of the number of times the function should appear in the binary. In the case of this test, C semantics means there should be three instances of inner_inline, while C++ semantics means there should be only two. On Windows, clang uses C++ inline semantics even for C code, and there doesn't seem to be a combination of compiler flags to avoid this. So, for consistency, I've recast the test to use C++ everywhere. Since the test resided under lang/c, it seemed appropriate to move it to lang/cpp. This does not address the other XFAIL for this test on Linux/gcc. See https://llvm.org/bugs/show_bug.cgi?id=26710 Differential Revision: http://reviews.llvm.org/D17650 llvm-svn: 262255
- Loading branch information
1 parent
936499a
commit 5361832
Showing
4 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...on/lldbsuite/test/lang/c/inlines/Makefile → .../lldbsuite/test/lang/cpp/inlines/Makefile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
LEVEL = ../../../make | ||
|
||
C_SOURCES := inlines.c | ||
CXX_SOURCES := inlines.cpp | ||
|
||
include $(LEVEL)/Makefile.rules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.