Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve Type::GetTypeScopeAndBasenameHelper and add unit tests
Previously it failed to handle nested types inside templated classes making it impossible to look up these types using the fully qualified name. Differential revision: https://reviews.llvm.org/D28466 llvm-svn: 291559
- Loading branch information
Tamas Berghammer
committed
Jan 10, 2017
1 parent
8e32aeb
commit 556b161
Showing
7 changed files
with
117 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
add_lldb_unittest(SymbolTests | ||
TestClangASTContext.cpp | ||
TestType.cpp | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
//===-- TestType.cpp --------------------------------------------*- C++ -*-===// | ||
// | ||
// | ||
// The LLVM Compiler Infrastructure | ||
// | ||
// This file is distributed under the University of Illinois Open Source | ||
// License. See LICENSE.TXT for details. | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "gtest/gtest.h" | ||
|
||
#include "lldb/Symbol/Type.h" | ||
|
||
using namespace lldb; | ||
using namespace lldb_private; | ||
|
||
namespace { | ||
void TestGetTypeScopeAndBasenameHelper(const char *full_type, | ||
bool expected_is_scoped, | ||
const char *expected_scope, | ||
const char *expected_name) { | ||
llvm::StringRef scope, name; | ||
lldb::TypeClass type_class; | ||
bool is_scoped = | ||
Type::GetTypeScopeAndBasename(full_type, scope, name, type_class); | ||
EXPECT_EQ(is_scoped, expected_is_scoped); | ||
if (expected_is_scoped) { | ||
EXPECT_EQ(scope, expected_scope); | ||
EXPECT_EQ(name, expected_name); | ||
} | ||
} | ||
}; | ||
|
||
TEST(Type, GetTypeScopeAndBasename) { | ||
TestGetTypeScopeAndBasenameHelper("int", false, "", ""); | ||
TestGetTypeScopeAndBasenameHelper("std::string", true, "std::", "string"); | ||
TestGetTypeScopeAndBasenameHelper("std::set<int>", true, "std::", "set<int>"); | ||
TestGetTypeScopeAndBasenameHelper("std::set<int, std::less<int>>", true, | ||
"std::", "set<int, std::less<int>>"); | ||
TestGetTypeScopeAndBasenameHelper("std::string::iterator", true, | ||
"std::string::", "iterator"); | ||
TestGetTypeScopeAndBasenameHelper("std::set<int>::iterator", true, | ||
"std::set<int>::", "iterator"); | ||
TestGetTypeScopeAndBasenameHelper( | ||
"std::set<int, std::less<int>>::iterator", true, | ||
"std::set<int, std::less<int>>::", "iterator"); | ||
TestGetTypeScopeAndBasenameHelper( | ||
"std::set<int, std::less<int>>::iterator<bool>", true, | ||
"std::set<int, std::less<int>>::", "iterator<bool>"); | ||
} |