Skip to content

Commit

Permalink
[clangd] NFC, emit source ranges in selection debug messages.
Browse files Browse the repository at this point in the history
It will make the output more versbose, but I found that these are useful
information when debugging selection tree.

Differential Revision: https://reviews.llvm.org/D117475
  • Loading branch information
hokein committed Jan 19, 2022
1 parent 0db30ad commit 55b702c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions clang-tools-extra/clangd/Selection.cpp
Expand Up @@ -548,7 +548,6 @@ std::string printNodeToString(const DynTypedNode &N, const PrintingPolicy &PP) {
std::string S;
llvm::raw_string_ostream OS(S);
printNodeKind(OS, N);
OS << " ";
return std::move(OS.str());
}
#endif
Expand Down Expand Up @@ -778,8 +777,8 @@ class SelectionVisitor : public RecursiveASTVisitor<SelectionVisitor> {
[](const Attr *A) { return !A->isImplicit(); }))
return false;
if (!SelChecker.mayHit(S)) {
dlog("{1}skip: {0}", printNodeToString(N, PrintPolicy), indent());
dlog("{1}skipped range = {0}", S.printToString(SM), indent(1));
dlog("{2}skip: {0} {1}", printNodeToString(N, PrintPolicy),
S.printToString(SM), indent());
return true;
}
return false;
Expand All @@ -798,7 +797,8 @@ class SelectionVisitor : public RecursiveASTVisitor<SelectionVisitor> {
// Performs early hit detection for some nodes (on the earlySourceRange).
void push(DynTypedNode Node) {
SourceRange Early = earlySourceRange(Node);
dlog("{1}push: {0}", printNodeToString(Node, PrintPolicy), indent());
dlog("{2}push: {0} {1}", printNodeToString(Node, PrintPolicy),
Node.getSourceRange().printToString(SM), indent());
Nodes.emplace_back();
Nodes.back().ASTNode = std::move(Node);
Nodes.back().Parent = Stack.top();
Expand Down

0 comments on commit 55b702c

Please sign in to comment.