Skip to content

Commit

Permalink
[ELF] - Repair dynsym-pie.s testcase.
Browse files Browse the repository at this point in the history
It was broken from begining, because visibility
attributes were not applied properly to
symbols before this patch.

Differential revision: https://reviews.llvm.org/D36966

llvm-svn: 311536
  • Loading branch information
George Rimar committed Aug 23, 2017
1 parent 3d55cef commit 55f207f
Showing 1 changed file with 48 additions and 4 deletions.
52 changes: 48 additions & 4 deletions lld/test/ELF/dynsym-pie.s
Expand Up @@ -3,6 +3,51 @@
# RUN: ld.lld -pie %t -o %t.out
# RUN: llvm-readobj -t -dyn-symbols %t.out | FileCheck %s

# CHECK: Symbols [
# CHECK: Symbol {
# CHECK: Name: hidden
# CHECK-NEXT: Value: 0x1000
# CHECK-NEXT: Size: 0
# CHECK-NEXT: Binding: Local
# CHECK-NEXT: Type: None
# CHECK-NEXT: Other [
# CHECK-NEXT: STV_HIDDEN
# CHECK-NEXT: ]
# CHECK-NEXT: Section: .text
# CHECK-NEXT: }
# CHECK: Symbol {
# CHECK: Name: internal
# CHECK-NEXT: Value: 0x1000
# CHECK-NEXT: Size: 0
# CHECK-NEXT: Binding: Local
# CHECK-NEXT: Type: None
# CHECK-NEXT: Other [
# CHECK-NEXT: STV_INTERNAL
# CHECK-NEXT: ]
# CHECK-NEXT: Section: .text
# CHECK-NEXT: }
# CHECK: Symbol {
# CHECK: Name: default
# CHECK-NEXT: Value: 0x1000
# CHECK-NEXT: Size: 0
# CHECK-NEXT: Binding: Global
# CHECK-NEXT: Type: None
# CHECK-NEXT: Other: 0
# CHECK-NEXT: Section: .text
# CHECK-NEXT: }
# CHECK: Symbol {
# CHECK: Name: protected
# CHECK-NEXT: Value: 0x1000
# CHECK-NEXT: Size: 0
# CHECK-NEXT: Binding: Global
# CHECK-NEXT: Type: None
# CHECK-NEXT: Other [
# CHECK-NEXT: STV_PROTECTED
# CHECK-NEXT: ]
# CHECK-NEXT: Section: .text
# CHECK-NEXT: }
# CHECK-NEXT: ]

# CHECK: DynamicSymbols [
# CHECK-NEXT: Symbol {
# CHECK-NEXT: Name: @
Expand All @@ -23,14 +68,13 @@ _start:
default:

.global protected
.protected protected
protected:

.global hidden
.hidden hidden
hidden:

.global internal
.internal internal
internal:

.global protected_with_hidden
.protected
protected_with_hidden:

0 comments on commit 55f207f

Please sign in to comment.