Skip to content

Commit

Permalink
Pre-commit reproducer for argument copy elison related bug
Browse files Browse the repository at this point in the history
Adding test case related to
  #89060

It shows that after argument copy elison the scheduler may reorder
a load of the input argument and a store to the same fixed stack
entry (the fixed stack entry that is reused for the local variable).
  • Loading branch information
bjope committed Apr 23, 2024
1 parent 9fb7a73 commit 56ed3dd
Showing 1 changed file with 41 additions and 0 deletions.
41 changes: 41 additions & 0 deletions llvm/test/CodeGen/Hexagon/arg-copy-elison.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
; RUN: llc -mtriple hexagon-- -o - %s | FileCheck %s

; Reproducer for https://github.com/llvm/llvm-project/issues/89060
;
; Problem was a bug in argument copy elison. Given that the %alloca is
; eliminated, the same frame index will be used for accessing %alloca and %a
; on the fixed stack. Care must be taken when setting up
; MachinePointerInfo/MemOperands for those accesses to either make sure that
; we always refer to the fixed stack slot the same way (not using the
; ir.alloca name), or make sure that we still detect that they alias each
; other if using different kinds of MemOperands to identify the same fixed
; stack entry.
;
define i32 @f(i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i32 %q1, i32 %a, i32 %q2) {
; CHECK-LABEL: f:
; CHECK: .cfi_startproc
; CHECK-NEXT: // %bb.0:
; CHECK-NEXT: {
; CHECK-NEXT: r0 = memw(r29+#36)
; CHECK-NEXT: memw(r29+#32) = ##666
; CHECK-NEXT: }
; CHECK-NEXT: {
; CHECK-NEXT: r1 = memw(r29+#28)
; CHECK-NEXT: r2 = memw(r29+#32)
; CHECK-NEXT: }
; CHECK-NEXT: {
; CHECK-NEXT: r0 = sub(r1,r0)
; CHECK-NEXT: }
; CHECK-NEXT: {
; CHECK-NEXT: r0 = xor(r0,r2)
; CHECK-NEXT: jumpr r31
; CHECK-NEXT: }
%alloca = alloca i32
store i32 %a, ptr %alloca ; Should be elided.
store i32 666, ptr %alloca
%x = sub i32 %q1, %q2
%y = xor i32 %x, %a ; Results in a load of %a from fixed stack.
; Using same frame index as elided %alloca.
ret i32 %y
}

0 comments on commit 56ed3dd

Please sign in to comment.